2008-09-12 08:39:21

by Manish Katiyar

Subject: [PATCH] debugfs : Fix usage of logdump command to make consistent with man page.

Below path adds the missing 's' option in the usage of logdump. Also
trivially replace "inode" with "filespec" to make consistent with man
page.


Signed-off-by: Manish Katiyar <[email protected]>

---
debugfs/logdump.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/debugfs/logdump.c b/debugfs/logdump.c
index fed9838..73680de 100644
--- a/debugfs/logdump.c
+++ b/debugfs/logdump.c
@@ -88,7 +88,7 @@ void do_logdump(int argc, char **argv)
struct journal_source journal_source;
struct ext2_super_block *es = NULL;

- journal_source.where = 0;
+ journal_source.where = JOURNAL_IS_INTERNAL;
journal_source.fd = 0;
journal_source.file = 0;
dump_all = 0;
@@ -264,7 +264,7 @@ errout:
return;

print_usage:
- fprintf(stderr, "%s: Usage: logdump [-ac] [-b<block>] [-i<inode>]\n\t"
+ fprintf(stderr, "%s: Usage: logdump [-acs] [-b<block>] [-i<filespec>]\n\t"
"[-f<journal_file>] [output_file]\n", argv[0]);
}

--
1.5.4.3


Thanks -
Manish

2008-10-01 23:56:26

by Theodore Ts'o

Subject: Re: [PATCH] debugfs : Fix usage of logdump command to make consistent with man page.

On Fri, Sep 12, 2008 at 02:09:19PM +0530, Manish Katiyar wrote:
> Below path adds the missing 's' option in the usage of logdump. Also
> trivially replace "inode" with "filespec" to make consistent with man
> page.

Thanks, applied.

- Ted