2009-03-02 06:41:37

by Manish Katiyar

Subject: [PATCH] jbd: Remove unnecessary check for NULL after calling kzalloc with __GFP_NOFAIL

Since new_transaction is allocated with __GFP_NOFAIL flags, NULL check
for the returned value is
not needed.

Signed-off-by: Manish Katiyar <[email protected]>
---
fs/jbd/transaction.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
index e6a1174..9e817fd 100644
--- a/fs/jbd/transaction.c
+++ b/fs/jbd/transaction.c
@@ -97,14 +97,9 @@ static int start_this_handle(journal_t *journal,
handle_t *handle)
}

alloc_transaction:
- if (!journal->j_running_transaction) {
+ if (!journal->j_running_transaction)
new_transaction = kzalloc(sizeof(*new_transaction),
GFP_NOFS|__GFP_NOFAIL);
- if (!new_transaction) {
- ret = -ENOMEM;
- goto out;
- }
- }

jbd_debug(3, "New handle %p going live.\n", handle);

--
1.5.4.3

Thanks -
Manish