2024-05-03 09:30:23

by Ritesh Harjani

Subject: [PATCH] ext2: Remove LEGACY_DIRECT_IO dependency

commit fb5de4358e1a ("ext2: Move direct-io to use iomap"), converted
ext2 direct-io to iomap which killed the call to blockdev_direct_IO().
So let's remove LEGACY_DIRECT_IO config dependency from ext2 Kconfig.

Signed-off-by: Ritesh Harjani (IBM) <[email protected]>
---
fs/ext2/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/ext2/Kconfig b/fs/ext2/Kconfig
index d6cfb1849580..d5bce83ad905 100644
--- a/fs/ext2/Kconfig
+++ b/fs/ext2/Kconfig
@@ -3,7 +3,6 @@ config EXT2_FS
tristate "Second extended fs support (DEPRECATED)"
select BUFFER_HEAD
select FS_IOMAP
- select LEGACY_DIRECT_IO
help
Ext2 is a standard Linux file system for hard disks.

--
2.44.0

2024-05-03 09:56:06

by Jan Kara

Subject: Re: [PATCH] ext2: Remove LEGACY_DIRECT_IO dependency

On Fri 03-05-24 14:58:52, Ritesh Harjani (IBM) wrote:
> commit fb5de4358e1a ("ext2: Move direct-io to use iomap"), converted
> ext2 direct-io to iomap which killed the call to blockdev_direct_IO().
> So let's remove LEGACY_DIRECT_IO config dependency from ext2 Kconfig.
>
> Signed-off-by: Ritesh Harjani (IBM) <[email protected]>

Thanks. Added to my tree.

Honza

> ---
> fs/ext2/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ext2/Kconfig b/fs/ext2/Kconfig
> index d6cfb1849580..d5bce83ad905 100644
> --- a/fs/ext2/Kconfig
> +++ b/fs/ext2/Kconfig
> @@ -3,7 +3,6 @@ config EXT2_FS
> tristate "Second extended fs support (DEPRECATED)"
> select BUFFER_HEAD
> select FS_IOMAP
> - select LEGACY_DIRECT_IO
> help
> Ext2 is a standard Linux file system for hard disks.
>
> --
> 2.44.0
>
--
Jan Kara <[email protected]>
SUSE Labs, CR