2023-07-26 15:43:48

by Wang Jianjian

Subject: [PATCH] jbd2: Remove unused t_handle_lock

Since commit f7f497cb7024 ("jbd2: kill t_handle_lock
transaction spinlock"), this lock has been no use.

Signed-off-by: Wang Jianjian <[email protected]>
---
include/linux/jbd2.h | 5 -----
1 file changed, 5 deletions(-)

diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
index d860499e15e4..8199235dbaf3 100644
--- a/include/linux/jbd2.h
+++ b/include/linux/jbd2.h
@@ -636,11 +636,6 @@ struct transaction_s
*/
struct list_head t_inode_list;

- /*
- * Protects info related to handles
- */
- spinlock_t t_handle_lock;
-
/*
* Longest time some handle had to wait for running transaction
*/
--
2.34.3

2023-07-31 09:49:42

by Ritesh Harjani (IBM)

Subject: Re: [PATCH] jbd2: Remove unused t_handle_lock

Wang Jianjian <[email protected]> writes:

> Since commit f7f497cb7024 ("jbd2: kill t_handle_lock
> transaction spinlock"), this lock has been no use.
>
Thanks for catching it. We should add fixes tag too.

Fixes: f7f497cb7024 ("jbd2: kill t_handle_lock transaction spinlock")

With that feel free to add -
Reviewed-by: Ritesh Harjani (IBM) <[email protected]>

-ritesh

2023-08-02 15:29:59

by Wang Jianjian

Subject: Re: [PATCH] jbd2: Remove unused t_handle_lock

Thanks. Fixed.

On 7/31/23 17:19, Ritesh Harjani (IBM) wrote:
> Reviewed-by: Ritesh Harjani (IBM)<[email protected]>