2009-07-01 21:52:11

by Kay Sievers

[permalink] [raw]
Subject: Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

On Wed, Jul 1, 2009 at 23:43, Theodore Tso<[email protected]> wrote:
> On Tue, Jun 30, 2009 at 12:17:02PM +0200, Kay Sievers wrote:
>>
>> And another thing is your custom "silent build" which can not be
>> disabled. Our build system requires the command output for fancy
>> analysis, so it would be good if it could be disabled, like it can for
>> the kernel (V=1). Any ideas, or do I miss some switch?
>
> Is a configure-level switch all that you need?  I hadn't done a
> make-level switch because I was trying to avoid adding a requirement
> of using GNU make in building e2fsprogs, since it gets used by *BSD
> and Solaris systems as well.  (And in fact some of the recent UUID bug
> fixes come from FreeBSD bug reports, and I suspect FreeBSD will
> continue to use UUID library from e2fsprogs rather than pulling in
> util-linux-ng....)

Anything would work, that resolves the '@' to nothing and puts out the
command, an environment var or a switch.

In older udev releases, before we switched to automake, I had
something like this, which behaves a bit like the Linux kernel build,
and V=1 switches off the silent mode:

V =
ifeq ($(strip $(V)),)
E = @echo
Q = @
else
E = @\#
Q =
endif
export E Q

...

$(E) " CC " [email protected]
$(Q) $(CC) -c $(CFLAGS) $< -o [email protected]

...

Thanks,
Kay


2009-07-01 22:36:37

by Mike Frysinger

[permalink] [raw]
Subject: Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

On Wednesday 01 July 2009 17:52:11 Kay Sievers wrote:
> On Wed, Jul 1, 2009 at 23:43, Theodore Tso<[email protected]> wrote:
> > On Tue, Jun 30, 2009 at 12:17:02PM +0200, Kay Sievers wrote:
> >> And another thing is your custom "silent build" which can not be
> >> disabled. Our build system requires the command output for fancy
> >> analysis, so it would be good if it could be disabled, like it can for
> >> the kernel (V=1). Any ideas, or do I miss some switch?
> >
> > Is a configure-level switch all that you need? I hadn't done a
> > make-level switch because I was trying to avoid adding a requirement
> > of using GNU make in building e2fsprogs, since it gets used by *BSD
> > and Solaris systems as well. (And in fact some of the recent UUID bug
> > fixes come from FreeBSD bug reports, and I suspect FreeBSD will
> > continue to use UUID library from e2fsprogs rather than pulling in
> > util-linux-ng....)
>
> Anything would work, that resolves the '@' to nothing and puts out the
> command, an environment var or a switch.
>
> In older udev releases, before we switched to automake, I had
> something like this, which behaves a bit like the Linux kernel build,
> and V=1 switches off the silent mode:

why not just use automake-1.11's silent-rules option. then you dont have to
waste time reinventing the wheel.
-mike


Attachments:
(No filename) (1.30 kB)
signature.asc (836.00 B)
This is a digitally signed message part.
Download all attachments

2009-07-02 00:59:14

by Theodore Ts'o

[permalink] [raw]
Subject: Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

On Wed, Jul 01, 2009 at 06:35:06PM -0400, Mike Frysinger wrote:
> > In older udev releases, before we switched to automake, I had
> > something like this, which behaves a bit like the Linux kernel build,
> > and V=1 switches off the silent mode:
>
> why not just use automake-1.11's silent-rules option. then you dont have to
> waste time reinventing the wheel.

Because I consider automake the spawn of Satan? :-)

- Ted

2009-07-02 01:17:21

by Mike Frysinger

[permalink] [raw]
Subject: Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

On Wednesday 01 July 2009 20:58:58 Theodore Tso wrote:
> On Wed, Jul 01, 2009 at 06:35:06PM -0400, Mike Frysinger wrote:
> > > In older udev releases, before we switched to automake, I had
> > > something like this, which behaves a bit like the Linux kernel build,
> > > and V=1 switches off the silent mode:
> >
> > why not just use automake-1.11's silent-rules option. then you dont have
> > to waste time reinventing the wheel.
>
> Because I consider automake the spawn of Satan? :-)

i'll have you know Satan's wheel is awfully shiny ...

Kay's rules look like they should be fairly straightforward to drop into
e2fsprogs. personally i'd use:
E = @:
when V=1, but this is probably just splitting hairs
-mike


Attachments:
(No filename) (716.00 B)
signature.asc (836.00 B)
This is a digitally signed message part.
Download all attachments