2021-11-04 06:35:29

by xu xin

[permalink] [raw]
Subject: [PATCH v2] ext4: Remove redundant statement

From: luo penghao <[email protected]>

The local variable assignment at the end of the function is meaningless.

The clang_analyzer complains as follows:

fs/ext4/fast_commit.c:779:2 warning:

Value stored to 'dst' is never read

change in v2:

Repair the sending email box

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: luo penghao <[email protected]>
---
fs/ext4/fast_commit.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
index 782d05a..9e5bfa0 100644
--- a/fs/ext4/fast_commit.c
+++ b/fs/ext4/fast_commit.c
@@ -797,7 +797,6 @@ static bool ext4_fc_add_dentry_tlv(struct super_block *sb, u16 tag,
ext4_fc_memcpy(sb, dst, &fcd, sizeof(fcd), crc);
dst += sizeof(fcd);
ext4_fc_memcpy(sb, dst, dname, dlen, crc);
- dst += dlen;

return true;
}
--
2.15.2



2022-01-05 23:39:55

by Theodore Ts'o

[permalink] [raw]
Subject: Re: [PATCH v2] ext4: Remove redundant statement

On Thu, 4 Nov 2021 06:34:06 +0000, [email protected] wrote:
> From: luo penghao <[email protected]>
>
> The local variable assignment at the end of the function is meaningless.
>
> The clang_analyzer complains as follows:
>
> fs/ext4/fast_commit.c:779:2 warning:
>
> [...]

Applied, thanks!

[1/1] ext4: remove redundant statement
commit: 756e311f7f200754096117caf9ef9d656edb280f

Best regards,
--
Theodore Ts'o <[email protected]>