2021-12-08 07:52:03

by xu xin

[permalink] [raw]
Subject: [PATCH linux-next] ext4: Remove redundant o_start statements

From: luo penghao <[email protected]>

The if will goto out of the loop, and until the end of the
function execution, o_start will not be used again.

The clang_analyzer complains as follows:

fs/ext4/move_extent.c:635:5 warning:

Value stored to 'o_start' is never read

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: luo penghao <[email protected]>
---
fs/ext4/move_extent.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c
index 64a5797..95aa212 100644
--- a/fs/ext4/move_extent.c
+++ b/fs/ext4/move_extent.c
@@ -632,7 +632,6 @@ ext4_move_extents(struct file *o_filp, struct file *d_filp, __u64 orig_blk,
/* Check hole before the start pos */
if (cur_blk + cur_len - 1 < o_start) {
if (next_blk == EXT_MAX_BLOCKS) {
- o_start = o_end;
ret = -ENODATA;
goto out;
}
--
2.15.2




2022-01-06 04:42:04

by Theodore Ts'o

[permalink] [raw]
Subject: Re: [PATCH linux-next] ext4: Remove redundant o_start statements

On Wed, 8 Dec 2021 07:51:57 +0000, [email protected] wrote:
> From: luo penghao <[email protected]>
>
> The if will goto out of the loop, and until the end of the
> function execution, o_start will not be used again.
>
> The clang_analyzer complains as follows:
>
> [...]

Applied, thanks!

[1/1] ext4: Remove redundant o_start statements
commit: b687e7ba0849122bf862639b98256a0b984a940a

Best regards,
--
Theodore Ts'o <[email protected]>