This a patch I've received from Veritas. Supposedly they have
already submitted this but I can't seem to find it in any 2.4 trees..
Does anybody recognize this and are there any known issues with it?
The Problem: The nfsd_findparent creates a dentry using d_alloc_root.
The d_op
vector pointer in this dentry is not initialized. Hence filesystems that
supply
the vector have a problem. nfs exports of such filesystems do not work
correctly under memory pressure. vxfs, vfat, ntfs are amongst the
filesystems
affected by the bug. Need redhat to fix nfsd code in their kernels.
Ideally
a kernel needs to ask a filesystem to setup a d_op vector. An entry point
into a filesystem for doing this job doesn't exist. We can work around the
problem by copying d_op vector pointer from the child of the dentry, whose
d_op vector is correct.
The Patch:
--- ./fs/nfsd/nfsfh.c.diff Wed Jul 2 13:17:35 2003
+++ ./fs/nfsd/nfsfh.c Tue Jul 29 04:45:43 2003
@@ -303,6 +303,7 @@ struct dentry *nfsd_findparent(struct de
if (pdentry) {
igrab(tdentry->d_inode);
pdentry->d_flags |=
DCACHE_NFSD_DISCONNECTED;
+ pdentry->d_op = child->d_op;
}
}
if (pdentry == NULL)
SteveD.
On Wed, 2003-08-06 at 18:11, Steve Dickson wrote:
> , vfat, ntfs
you can't NFS export vfat..... for lots of other reasons
On Wed, 6 Aug 2003, Steve Dickson wrote:
> This a patch I've received from Veritas. Supposedly they have
> already submitted this but I can't seem to find it in any 2.4 trees..
>
> Does anybody recognize this and are there any known issues with it?
It makes me wonder what is so special about vxfs that they need
to modify GPL code in order for it to work ...
Not that I'm against this change in principle, but I'd just like
it to be useful for GPL software too, otherwise it'd just be a
hook for non-GPL software and a fine line to a GPL violation.
--
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan