This one could be considered a false positive since the only call to
nfs4_acl_nfsv4_to_posix() passes in a non-NULL pointer to dpacl, but the
code does check for non-NULL dpacl later.
Signed-off by: Frank Filz
diff --git a/fs/nfsd/nfs4acl.c b/fs/nfsd/nfs4acl.c
--- a/fs/nfsd/nfs4acl.c
+++ b/fs/nfsd/nfs4acl.c
@@ -378,7 +378,9 @@ nfs4_acl_nfsv4_to_posix(struct nfs4_acl
int error = -ENOMEM;
*pacl = NULL;
- *dpacl = NULL;
+
+ if (dpacl != NULL)
+ *dpacl = NULL;
dacl = nfs4_acl_new();
if (dacl == NULL)
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs