2006-10-17 17:24:44

by Frank Filz

Subject: [patch 2/4] NFS: Remove use of the Big Kernel Lock around calls to rpc_execute.

Remove use of the Big Kernel Lock around calls to rpc_execute.

Signed-off-by: Frank Filz <[email protected]>

### Diffstat output
direct.c | 6 ------
read.c | 2 --
write.c | 2 --
3 files changed, 10 deletions(-)

diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c
index 9f7f8b9..ff943ab 100644
--- a/fs/nfs/direct.c
+++ b/fs/nfs/direct.c
@@ -307,9 +307,7 @@ static ssize_t nfs_direct_read_schedule(

data->task.tk_cookie = (unsigned long) inode;

- lock_kernel();
rpc_execute(&data->task);
- unlock_kernel();

dfprintk(VFS, "NFS: %5u initiated direct read call (req %s/%Ld, %zu
bytes @ offset %Lu)\n",
data->task.tk_pid,
@@ -475,9 +473,7 @@ static void nfs_direct_commit_schedule(s

dprintk("NFS: %5u initiated commit call\n", data->task.tk_pid);

- lock_kernel();
rpc_execute(&data->task);
- unlock_kernel();
}

static void nfs_direct_write_complete(struct nfs_direct_req *dreq,
struct inode *inode)
@@ -637,9 +633,7 @@ static ssize_t nfs_direct_write_schedule
data->task.tk_priority = RPC_PRIORITY_NORMAL;
data->task.tk_cookie = (unsigned long) inode;

- lock_kernel();
rpc_execute(&data->task);
- unlock_kernel();

dfprintk(VFS, "NFS: %5u initiated direct write call (req %s/%Ld, %zu
bytes @ offset %Lu)\n",
data->task.tk_pid,
diff --git a/fs/nfs/read.c b/fs/nfs/read.c
index c2e49c3..9ca6910 100644
--- a/fs/nfs/read.c
+++ b/fs/nfs/read.c
@@ -316,9 +316,7 @@ static void nfs_execute_read(struct nfs_
sigset_t oldset;

rpc_clnt_sigmask(clnt, &oldset);
- lock_kernel();
rpc_execute(&data->task);
- unlock_kernel();
rpc_clnt_sigunmask(clnt, &oldset);
}

diff --git a/fs/nfs/write.c b/fs/nfs/write.c
index f6675d2..3d0470b 100644
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@ -977,9 +977,7 @@ static void nfs_execute_write(struct nfs
sigset_t oldset;

rpc_clnt_sigmask(clnt, &oldset);
- lock_kernel();
rpc_execute(&data->task);
- unlock_kernel();
rpc_clnt_sigunmask(clnt, &oldset);
}




-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

2006-10-18 22:34:18

by Trond Myklebust

Subject: Re: [patch 2/4] NFS: Remove use of the Big Kernel Lock around calls to rpc_execute.

On Tue, 2006-10-17 at 10:24 -0700, Frank Filz wrote:
> Remove use of the Big Kernel Lock around calls to rpc_execute.
>

This one had been seriously mangled by your emailer... I've been able to
piece it together and apply, though...

Cheers,
Trond


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs