The function nfs_verify_change_attributes() is misleading and no longer
required if [PATCH 1/2] of this patchset is included. One would normally
expect the function to return true if there is a change in attributes
but, the function does the other way around.
* Please note that this patch assumes inclusion of the previous patch
[PATCH 1/2] nfs: Fix i_size update in O_DIRECT write which remove the
last invocation of this function.
Signed-off-by: Suresh Jayaraman <[email protected]>
---
include/linux/nfs_fs.h | 13 -------------
1 files changed, 0 insertions(+), 13 deletions(-)
diff --git a/include/linux/nfs_fs.h b/include/linux/nfs_fs.h
index 7250eea..d103cc0 100644
--- a/include/linux/nfs_fs.h
+++ b/include/linux/nfs_fs.h
@@ -264,19 +264,6 @@ static inline long nfs_save_change_attri
return NFS_I(inode)->cache_change_attribute;
}
-/**
- * nfs_verify_change_attribute - Detects NFS inode cache updates
- * @inode - pointer to inode
- * @chattr - previously saved change attribute
- * Return "false" if metadata has been updated (or is in the process of
- * being updated) since the change attribute was saved.
- */
-static inline int nfs_verify_change_attribute(struct inode *inode, unsigned long chattr)
-{
- return !nfs_caches_unstable(inode)
- && time_after_eq(chattr, NFS_I(inode)->cache_change_attribute);
-}
-
/*
* linux/fs/nfs/inode.c
*/
--
Suresh Jayaraman
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs