2002-10-21 23:40:46

by NeilBrown

Subject: Re: [BUG][PATCH] NFS over TCP doesn't work on linux-2.5.43

On Friday October 18, [email protected] wrote:
> Hello,
>
> I found another problem that argbuf and resbuf may be overlapped.
> We should throw away previous one and apply a new patch.
>
> > I've solved the problem that NFS over TCP doesn't work on linux-2.5.43.
> > Could you apply it?
>

Thanks for noticing this.
I think the following it patch is simpler and achieves the same
result. Could you please check that it addresses the issues you
discovered?

NeilBrown

--- ./net/sunrpc/svcsock.c 2002/10/21 23:26:40 1.1
+++ ./net/sunrpc/svcsock.c 2002/10/21 23:33:06
@@ -882,9 +882,9 @@ svc_tcp_recvfrom(struct svc_rqst *rqstp)

dprintk("svc: TCP complete record (%d bytes)\n", len);

- /* Position reply write pointer immediately args,
+ /* Position reply write pointer immediately after args,
* allowing for record length */
- rqstp->rq_resbuf.base = rqstp->rq_argbuf.base + (len>>2);
+ rqstp->rq_resbuf.base = rqstp->rq_argbuf.base + 1 + (len>>2);
rqstp->rq_resbuf.buf = rqstp->rq_resbuf.base + 1;
rqstp->rq_resbuf.len = 1;
rqstp->rq_resbuf.buflen= rqstp->rq_argbuf.buflen - (len>>2) - 1;
@@ -892,7 +892,7 @@ svc_tcp_recvfrom(struct svc_rqst *rqstp)
rqstp->rq_skbuff = 0;
rqstp->rq_argbuf.buf += 1;
rqstp->rq_argbuf.len = (len >> 2);
- rqstp->rq_argbuf.buflen = (len >> 2);
+ rqstp->rq_argbuf.buflen = (len >> 2) +1;
rqstp->rq_prot = IPPROTO_TCP;

/* Reset TCP read info */


-------------------------------------------------------
This sf.net emial is sponsored by: Influence the future
of Java(TM) technology. Join the Java Community
Process(SM) (JCP(SM)) program now.
http://ad.doubleclick.net/clk;4699841;7576298;k?http://www.sun.com/javavote
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

2002-10-22 03:37:34

by Hirokazu Takahashi

Subject: Re: [BUG][PATCH] NFS over TCP doesn't work on linux-2.5.43

Hello,

I looks better and I've checked it will work good!

> > I found another problem that argbuf and resbuf may be overlapped.
> > We should throw away previous one and apply a new patch.
> >
> > > I've solved the problem that NFS over TCP doesn't work on linux-2.5.43.
> > > Could you apply it?
> >
>
> Thanks for noticing this.
> I think the following it patch is simpler and achieves the same
> result. Could you please check that it addresses the issues you
> discovered?

Thank you,
Hirokazu Takahashi.


-------------------------------------------------------
This sf.net emial is sponsored by: Influence the future
of Java(TM) technology. Join the Java Community
Process(SM) (JCP(SM)) program now.
http://ad.doubleclick.net/clk;4699841;7576298;k?http://www.sun.com/javavote
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs