2002-03-27 09:20:25

by Kurt Garloff

[permalink] [raw]
Subject: [[email protected]: linux-2.4.18-rpc_tweaks.dif]

Hi,

Yusuf Goolamabbas asked me to send this here as well.
In case you reply, please Cc: me, as I'm not on the NFS list.

----- Forwarded message from Kurt Garloff <[email protected]> -----

Date: Wed, 27 Mar 2002 03:27:36 +0100
From: Kurt Garloff <[email protected]>
To: Trond Myklebust <[email protected]>
Cc: Linux kernel list <[email protected]>
Subject: linux-2.4.18-rpc_tweaks.dif
Mail-Followup-To: Kurt Garloff <[email protected]>,
Trond Myklebust <[email protected]>,
Linux kernel list <[email protected]>
User-Agent: Mutt/1.3.22.1i
X-Operating-System: Linux 2.4.16-schedJ2 i686
X-PGP-Info: on http://www.garloff.de/kurt/mykeys.pgp
X-PGP-Key: 1024D/1C98774E, 1024R/CEFC9215
Organization: TU/e(NL), SuSE(DE)

Hi Trond,

http://www.fys.uio.no/~trondmy/src/2.4.18/linux-2.4.18-rpc_tweaks.dif
contains a change that causes devastating NFS client performance: My NFS
read performance on a switched 100BaseT went down from >9MB/s to 500kB/s.
(NFSv3, rsize=8192, 2.4.16 AXP kernel nfsd server)

The reason is that
xprt_adjust_cwnd()
does no longer do what the comment above says it should do:
_slowly_ increase cwnd until we start to hit the limit (which we see from
timed out requests). Instead cwnd gets bumped very fast resulting in lots of
timed out requests. This way you get fast oscillations in cwnd.

Putting the old code back for xprt_adjust_cwnd() gave me back the old
performance.

Except for the missing damping, comparing the functionality with the old
code, e.g. this snippet
+ if (xprt->cong > cwnd)
+ goto out;
also makes me wonder whether it could be correct.
Please have a look at it again!

Regards,
--
Kurt Garloff <[email protected]> [Eindhoven, NL]
Physics: Plasma simulations <[email protected]> [TU Eindhoven, NL]
Linux: SCSI, Security <[email protected]> [SuSE Nuernberg, DE]
(See mail header or public key servers for PGP2 and GPG public keys.)



----- End forwarded message -----

--
Kurt Garloff <[email protected]> [Eindhoven, NL]
Physics: Plasma simulations <[email protected]> [TU Eindhoven, NL]
Linux: SCSI, Security <[email protected]> [SuSE Nuernberg, DE]
(See mail header or public key servers for PGP2 and GPG public keys.)


Attachments:
(No filename) (2.23 kB)
(No filename) (232.00 B)
Download all attachments