Hi,
Here's another patch that has been sitting in our tree for a while, which
should probably go in upstream. Changelog:
=== snip ===
Author: Steinar H. Gunderson <[email protected]>
Date: Mon, 20 Nov 2006 23:46:32 +0100
Use memset instead of __bzero. bzero has been deprecated
for years (and anything starting with __ is an internal
function anyhow), and __bzero seems to have broken on ia64
not too long ago.
=== snip ===
diff -ur nfs-utils-1.0.10.orig/support/nfs/svc_socket.c nfs-utils-1.0.10/support/nfs/svc_socket.c
--- nfs-utils-1.0.10.orig/support/nfs/svc_socket.c 2006-08-07 08:40:50.000000000 +0200
+++ nfs-utils-1.0.10/support/nfs/svc_socket.c 2006-11-20 23:46:05.000000000 +0100
@@ -64,7 +64,7 @@
}
}
- __bzero ((char *) &addr, sizeof (addr));
+ memset (&addr, 0, sizeof (addr));
addr.sin_family = AF_INET;
ret = getrpcbynumber_r (number, &rpcbuf, rpcdata, sizeof rpcdata,
/* Steinar */
--
Homepage: http://www.sesse.net/
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
On Mon, Nov 20, 2006 at 11:47:52PM +0100, Steinar H. Gunderson wrote:
> Here's another patch that has been sitting in our tree for a while, which
> should probably go in upstream. Changelog:
The subject is wrong, of course; I forgot to fix it when just copying the
previous mail. Sorry about that. :-)
/* Steinar */
--
Homepage: http://www.sesse.net/
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
On Mon, 2006-11-20 at 23:47 +0100, Steinar H. Gunderson wrote:
> Hi,
>
> Here's another patch that has been sitting in our tree for a while, which
> should probably go in upstream. Changelog:
>
> === snip ===
> Author: Steinar H. Gunderson <[email protected]>
> Date: Mon, 20 Nov 2006 23:46:32 +0100
>
> Use memset instead of __bzero. bzero has been deprecated
> for years (and anything starting with __ is an internal
> function anyhow), and __bzero seems to have broken on ia64
> not too long ago.
> === snip ===
When sending in patches like this, could you please also add in a
'Signed-off-by' line as per the Developer's Certificate of Origin 1.1
(See Documentation/SubmittingPatches in the Linux kernel source).
Admittedly the patch you sent in was extremely unlikely to be subject to
any special intellectual property claims, but this is a matter of good
coding practice.
Cheers
Trond
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
On Tue, Nov 21, 2006 at 12:02:34AM -0500, Trond Myklebust wrote:
> When sending in patches like this, could you please also add in a
> 'Signed-off-by' line as per the Developer's Certificate of Origin 1.1
> (See Documentation/SubmittingPatches in the Linux kernel source).
Sure, I'll keep it in mind.
/* Steinar */
--
Homepage: http://www.sesse.net/
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs