2007-07-18 17:09:37

by Steinar H. Gunderson

[permalink] [raw]
Subject: [PATCH] Properly ignore quota options

Hi,

Now that NFS mounting has been taken over by nfs-utils, it seems like I've
gotten a few bugs on my hands. The included patch is based on a user
suggestion from about a year ago. It would be great if someone could also
check out these two bugs:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=301955
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=301953


The mount(5) man page states that the noquota, quota, usrquota and
grpquota options are ignored. (They are, however, used by the quota
tools, so having them in fstab can be useful.) Make mount.nfs ignore
them properly, matching the man page. There are a few aliases (like
usrjquota) that are parsed by quota, but as these are not documented
nor seem to be widely used, they are not included.

Signed-off-by: Steinar H. Gunderson <[email protected]>

Index: nfs-utils-1.1.0/utils/mount/mount.c
===================================================================
--- nfs-utils-1.1.0.orig/utils/mount/mount.c
+++ nfs-utils-1.1.0/utils/mount/mount.c
@@ -132,6 +132,10 @@ static const struct opt_map opt_map[] =
{ "diratime", 0, 1, MS_NODIRATIME }, /* Update dir access times */
{ "nodiratime", 0, 0, MS_NODIRATIME },/* Do not update dir access times */
#endif
+ { "noquota", 0, 0, MS_DUMMY }, /* Don't enforce quota */
+ { "quota", 0, 0, MS_DUMMY }, /* Enforce user quota */
+ { "usrquota", 0, 0, MS_DUMMY }, /* Enforce user quota */
+ { "grpquota", 0, 0, MS_DUMMY }, /* Enforce group quota */
{ NULL, 0, 0, 0 }
};

/* Steinar */
--
Homepage: http://www.sesse.net/

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs


2007-09-29 13:08:59

by Steinar H. Gunderson

[permalink] [raw]
Subject: Re: [PATCH] Properly ignore quota options

On Wed, Jul 18, 2007 at 07:09:31PM +0200, Steinar H. Gunderson wrote:
> The mount(5) man page states that the noquota, quota, usrquota and
> grpquota options are ignored. (They are, however, used by the quota
> tools, so having them in fstab can be useful.) Make mount.nfs ignore
> them properly, matching the man page. There are a few aliases (like
> usrjquota) that are parsed by quota, but as these are not documented
> nor seem to be widely used, they are not included.
>
> Signed-off-by: Steinar H. Gunderson <[email protected]>

This patch was also dropped on the floor. Neil?

/* Steinar */
--
Homepage: http://www.sesse.net/

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs