2006-06-13 02:41:50

by Ian Kent

[permalink] [raw]
Subject: Re: [PATCH 2 / 2] Move NFS mount code from util-linux to nfs-utils - take2


Hi Amit,

I see that the mtab locking here has the patches that should make it
work properly (at least I believe that is the case) but if that same fix
is not implemented in the util-linux code base then the problem will
persist.

Perhaps Adrian Bunk should be involved in this since he will ultimately
need to update util-linux as well?

Ian



_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

2006-06-13 03:33:02

by Amit Gud

[permalink] [raw]
Subject: Re: [PATCH 2 / 2] Move NFS mount code from util-linux tonfs-utils - take2

Ian Kent wrote:
> Hi Amit,
>
> I see that the mtab locking here has the patches that should make it
> work properly (at least I believe that is the case) but if that same fix
> is not implemented in the util-linux code base then the problem will
> persist.
>
> Perhaps Adrian Bunk should be involved in this since he will ultimately
> need to update util-linux as well?
>

util-linux already uses this locking protocol (which is included in the
patches), in fact that code is duplicated now in nfs-utils. But theres
code like the samba client (mount.cifs), that doesn't follow this and
have implemented some different mechanism.


AG
--
May the source be with you.
http://www.cis.ksu.edu/~gud



_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

2006-06-13 13:13:08

by Ian Kent

[permalink] [raw]
Subject: Re: [PATCH 2 / 2] Move NFS mount code from util-linux tonfs-utils - take2

On Mon, 2006-06-12 at 23:36 -0400, Amit Gud wrote:
> Ian Kent wrote:
> > Hi Amit,
> >
> > I see that the mtab locking here has the patches that should make it
> > work properly (at least I believe that is the case) but if that same fix
> > is not implemented in the util-linux code base then the problem will
> > persist.
> >
> > Perhaps Adrian Bunk should be involved in this since he will ultimately
> > need to update util-linux as well?
> >
>
> util-linux already uses this locking protocol (which is included in the
> patches), in fact that code is duplicated now in nfs-utils. But theres
> code like the samba client (mount.cifs), that doesn't follow this and
> have implemented some different mechanism.

My point is that the code in util-linux does not do the locking properly
and if it is not fixed then the locking here isn't worth anything.

Ian



_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs