2005-03-08 06:07:22

by NeilBrown

[permalink] [raw]
Subject: [PATCH kNFSd 21 of 54] nfsd4: remove unnecessary check in find_delegation_stateid



We would have oopsed some time ago if either of these parameters were NULL.

Signed-off-by: J. Bruce Fields <[email protected]>
Signed-off-by: Neil Brown <[email protected]>

### Diffstat output
./fs/nfsd/nfs4state.c | 2 --
1 files changed, 2 deletions(-)

diff ./fs/nfsd/nfs4state.c~current~ ./fs/nfsd/nfs4state.c
--- ./fs/nfsd/nfs4state.c~current~ 2005-03-07 11:35:56.000000000 +1100
+++ ./fs/nfsd/nfs4state.c 2005-03-07 11:35:56.000000000 +1100
@@ -2450,8 +2450,6 @@ find_delegation_stateid(struct inode *in
stid->si_boot, stid->si_stateownerid,
stid->si_fileid, stid->si_generation);

- if(!ino || !stid)
- return NULL;
st_id = stid->si_stateownerid;
fi_hashval = file_hashval(ino);
if (find_file(fi_hashval, ino, &fp)) {


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs