2004-02-27 23:58:54

by Bruce Allan

[permalink] [raw]
Subject: NFS lockd and clustered filesystems






Hi Trond,

I've been asked to look into an issue that has been previously discussed
both on and off the lkml. The issue is with lockd not invoking a
filesystem-specific locking function if one is defined, such as with
out-of-tree cluster filesystems. You may recall the discussions you had
with Brian Dixon regarding this sometime ago [1]; you didn't like Brian's
patch because such a filesystem call could hang the single-threaded lockd.
As I understand it, there was further (off-list?) discussion regarding
making lockd multi-threaded to get around this problem. In light of recent
announcements/discussions regarding cluster filesystems on Linux (eg.
RedHat's acquisition of Sistina, Linus' remarks about clustered filesystems
being one of the main things to work on for 2.7), is the time right to
re-address this matter? How receptive would you be to these previous
patches (including the multi-threaded lockd patch) being ported to 2.6, or
would you prefer another method?

[1] - http://marc.theaimsgroup.com/?l=linux-kernel&m=102045853603944&w=2

Regards,
---
Bruce Allan <[email protected]>
Software Engineer, Linux Technology Center
IBM Corporation, Beaverton OR
503-578-4187 IBM Tie-line 775-4187


Attachments:
(No filename) (1.36 kB)

2004-02-28 00:32:07

by Trond Myklebust

[permalink] [raw]
Subject: Re: NFS lockd and clustered filesystems

P=E5 fr , 27/02/2004 klokka 15:55, skreiv Bruce Allan:
> Hi Trond,
>
> I've been asked to look into an issue that has been previously
> discussed both on and off the lkml. The issue is with lockd not
> invoking a filesystem-specific locking function if one is defined,
> such as with out-of-tree cluster filesystems. You may recall the
> discussions you had with Brian Dixon regarding this sometime
> ago [1]; you didn't like Brian's patch because such a filesystem
> call could hang the single-threaded lockd. As I understand it,
> there was further (off-list?) discussion regarding making lockd
> multi-threaded to get around this problem. In light of recent
> announcements/discussions regarding cluster filesystems on
> Linux (eg. RedHat's acquisition of Sistina, Linus' remarks about
> clustered filesystems being one of the main things to work on
> for 2.7), is the time right to re-address this matter? How
> receptive would you be to these previous patches
> (including the multi-threaded lockd patch) being ported to 2.6,
> or would you prefer another method?

I have no philosophical objections to doing this as long as the issue o=
f
lockd potentially hanging is addressed.

Note, though, that Brian's patch can probably be implemented in a more
efficient manner in 2.6.x now that we have generic workqueues in the
kernel. They could be used to offload the work without having to fork a
bunch of threads every time someone wants to use the cluster system.

Cheers,
Trond