_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
On Fri, Jul 27, 2007 at 03:48:06PM -0400, Chuck Lever wrote:
> Hi all-
>
> It would be nice to enable more static code checking in nfs-utils (I'm
> especially interested in utils/mount/). Is there a clean way to add
> additional CFLAGS, like -Wall, to utils/mount/Makefile using the autotools
> set up? How about a lint or sparse target?
I don't know, sounds like a good idea.
Last I checked, though, I thought there were still a fair number of
warnings just with the current defaults. Maybe we should fix those up
first?
--b.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
----- Original Message -----
From: Chuck Lever <[email protected]>
Date: Friday, July 27, 2007 1:19 pm
Subject: Re: [NFS] wonky autotools question
To: "J. Bruce Fields" <[email protected]>
Cc: [email protected]
> J. Bruce Fields wrote:
> > On Fri, Jul 27, 2007 at 03:48:06PM -0400, Chuck Lever wrote:
> >> Hi all-
> >>
> >> It would be nice to enable more static code checking in nfs-
> utils (I'm
> >> especially interested in utils/mount/). Is there a clean way to
> add
> >> additional CFLAGS, like -Wall, to utils/mount/Makefile using the
> autotools
> >> set up? How about a lint or sparse target?
> >
> > I don't know, sounds like a good idea.
>
> So far, "CFLAGS=-Wall -O2 -g ./configure" enables full warnings
> everywhere in the tree, but I haven't found anything on how to
> specify
> additional CFLAGS in one subdir, and have it happen automatically.
>
> > Last I checked, though, I thought there were still a fair number of
> > warnings just with the current defaults. Maybe we should fix
> those up
> > first?
>
> I'm focusing on utils/mount at the moment, and that seems pretty
> clean
> with the present C flags. I have noticed warnings in other parts
> of the
> tree, but haven't had time to poke at them.
In configure.ac, add something like this:
GCC_WARNING_FLAGS=""
if test "x$GCC" = "xyes" ;then
GCC_WARNING_FLAGS="-Wall -O2 -g"
fi
AC_SUBST(GCC_WARNING_FLAGS)
And then in utils/mount/Makefile.am, add something like this:
mount_CFLAGS = $(GCC_WARNING_FLAGS)
This is a pretty generic answer because I haven't actually looked at the source tree to know if these are correct for your autotools stuff. If you like, I can grab it and send you a patch.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
On Friday July 27, [email protected] wrote:
>
> Though really, it does make sense to set -Wall for the whole package.
> Would anyone mind if I sent a patch that did that?
I'd be keen on
-Wall -Werror -Wstrict-prototypes
though I suspect we need a lot of cleanup before all of those can
pass, and we -Werror would have to be conditional on using the
internal rpcgen as the libc one generates code that produced warning.
I guess I really should try pushing those rpcgen fixes upstream to
glibc...
NeilBrown
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs