When compiling userspace tools with
(GCC) 4.6.0 20100416 I'm getting this error:
booleans.c: In function 'sepol_bool_count':
booleans.c:106:39: error: parameter 'handle' set but not used
cc1: all warnings being treated as errors
This patch is a temporary fix and/or perminent
(depending on what you guys decide).
Signed-off-by: Justin P. Mattock <[email protected]>
---
checkpolicy/Makefile | 2 +-
libsepol/src/Makefile | 2 +-
libsepol/utils/Makefile | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/checkpolicy/Makefile b/checkpolicy/Makefile
index e5fae3d..34fa857 100644
--- a/checkpolicy/Makefile
+++ b/checkpolicy/Makefile
@@ -10,7 +10,7 @@ TARGETS = checkpolicy checkmodule
YACC = bison -y
-CFLAGS ?= -g -Wall -Werror -Wshadow -O2 -pipe -fno-strict-aliasing
+CFLAGS ?= -g -Wall -Wshadow -O2 -pipe -fno-strict-aliasing
override CFLAGS += -I. -I${INCLUDEDIR}
diff --git a/libsepol/src/Makefile b/libsepol/src/Makefile
index 73fdef8..be0d4d8 100644
--- a/libsepol/src/Makefile
+++ b/libsepol/src/Makefile
@@ -14,7 +14,7 @@ LIBPC=libsepol.pc
LIBSO=$(TARGET).$(LIBVERSION)
OBJS= $(patsubst %.c,%.o,$(wildcard *.c))
LOBJS= $(patsubst %.c,%.lo,$(wildcard *.c))
-CFLAGS ?= -Werror -Wall -W -Wundef -Wshadow -Wmissing-noreturn -Wmissing-format-attribute
+CFLAGS ?= -Wall -W -Wundef -Wshadow -Wmissing-noreturn -Wmissing-format-attribute
override CFLAGS += -I. -I../include -D_GNU_SOURCE
all: $(LIBA) $(LIBSO) $(LIBPC)
diff --git a/libsepol/utils/Makefile b/libsepol/utils/Makefile
index 6864114..9985cf6 100644
--- a/libsepol/utils/Makefile
+++ b/libsepol/utils/Makefile
@@ -2,7 +2,7 @@
PREFIX ?= $(DESTDIR)/usr
BINDIR ?= $(PREFIX)/bin
-CFLAGS ?= -Wall -Werror
+CFLAGS ?= -Wall
override CFLAGS += -I../include
LDLIBS += -L../src -lsepol
--
1.7.1.rc1.21.gf3bd6
On Sat, 2010-05-08 at 00:30 -0700, Justin P. Mattock wrote:
> When compiling userspace tools with
> (GCC) 4.6.0 20100416 I'm getting this error:
>
> booleans.c: In function 'sepol_bool_count':
> booleans.c:106:39: error: parameter 'handle' set but not used
> cc1: all warnings being treated as errors
>
> This patch is a temporary fix and/or perminent
> (depending on what you guys decide).
Removing -Werror isn't a "fix". To fix, add __attribute__((unused)) as
appropriate.
>
>
>
> Signed-off-by: Justin P. Mattock <[email protected]>
> ---
> checkpolicy/Makefile | 2 +-
> libsepol/src/Makefile | 2 +-
> libsepol/utils/Makefile | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/checkpolicy/Makefile b/checkpolicy/Makefile
> index e5fae3d..34fa857 100644
> --- a/checkpolicy/Makefile
> +++ b/checkpolicy/Makefile
> @@ -10,7 +10,7 @@ TARGETS = checkpolicy checkmodule
>
> YACC = bison -y
>
> -CFLAGS ?= -g -Wall -Werror -Wshadow -O2 -pipe -fno-strict-aliasing
> +CFLAGS ?= -g -Wall -Wshadow -O2 -pipe -fno-strict-aliasing
>
> override CFLAGS += -I. -I${INCLUDEDIR}
>
> diff --git a/libsepol/src/Makefile b/libsepol/src/Makefile
> index 73fdef8..be0d4d8 100644
> --- a/libsepol/src/Makefile
> +++ b/libsepol/src/Makefile
> @@ -14,7 +14,7 @@ LIBPC=libsepol.pc
> LIBSO=$(TARGET).$(LIBVERSION)
> OBJS= $(patsubst %.c,%.o,$(wildcard *.c))
> LOBJS= $(patsubst %.c,%.lo,$(wildcard *.c))
> -CFLAGS ?= -Werror -Wall -W -Wundef -Wshadow -Wmissing-noreturn -Wmissing-format-attribute
> +CFLAGS ?= -Wall -W -Wundef -Wshadow -Wmissing-noreturn -Wmissing-format-attribute
> override CFLAGS += -I. -I../include -D_GNU_SOURCE
>
> all: $(LIBA) $(LIBSO) $(LIBPC)
> diff --git a/libsepol/utils/Makefile b/libsepol/utils/Makefile
> index 6864114..9985cf6 100644
> --- a/libsepol/utils/Makefile
> +++ b/libsepol/utils/Makefile
> @@ -2,7 +2,7 @@
> PREFIX ?= $(DESTDIR)/usr
> BINDIR ?= $(PREFIX)/bin
>
> -CFLAGS ?= -Wall -Werror
> +CFLAGS ?= -Wall
> override CFLAGS += -I../include
> LDLIBS += -L../src -lsepol
>
--
Stephen Smalley
National Security Agency