I thought my patch was merged but my name was not in the Changelog in the
latest version.
Mine was too minor to be open to public?
Thanks.
--
?????????????????????????
http://heavymetalhardrock.no-ip.info/ <http://www.heavymetalhardrock.tk/>
???????????SELinux??????????????
http://sourceforge.net/projects/segatex/
CMS?PHP?PostgreSQL???????????
http://sourceforge.net/projects/webon/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://oss.tresys.com/pipermail/refpolicy/attachments/20140314/57e335b2/attachment.html
On 03/14/2014 10:29 AM, Shintaro Fujiwara wrote:
> I thought my patch was merged but my name was not in the Changelog in the latest version.
>
> Mine was too minor to be open to public?
>
> Thanks.
We're definitely not trying to avoid giving people credit for their contributions. I generate the changelog by using 'git shortlog'. If a patch is correctly sent via git format-patch and git send-email, I can apply it with git am, and the author will show up as you'd expect in the changelog (Like Dominick, Dan Walsh, and I do). Showing up as the author in the changelog is another reason to submit patches this way.
If Dominick or I have to manually apply a patch, we will show up as the author. We try to make sure the original author is mentioned in the commit message, but if we mistakenly forgot you, I apologize.
One thing you may be unaware of is that contrib now has its own changelog. I will create a symlink in the policy root directory to the contrib changelog. In the contrib changelog, I see that Dominick merged a patch from you that fixed a typo in ksmtuned_admin(); is this the patch you are referring to?
--
Chris PeBenito
Tresys Technology, LLC
http://www.tresys.com | oss.tresys.com
On Fri, 2014-03-14 at 10:49 -0400, Christopher J. PeBenito wrote:
> On 03/14/2014 10:29 AM, Shintaro Fujiwara wrote:
> > I thought my patch was merged but my name was not in the Changelog in the latest version.
> >
> I see that Dominick merged a patch from you that fixed a typo in ksmtuned_admin(); is this the patch you are referring to?
>
Yes that is probably the one, sorry about that.
I was not a git formatted patch, and there was another typo. I did not
merge that patch as is.
I understand what you say and really appreciate Dominick's job.
I am not so much talented guy and I found that miss-typed thing just making
my segatex.
The shell script I wrote found an minor error and I was glad that I found
it and I had an former experience that I found my name on Changelog, so I
was expecting that I could be in there again.
I think it's totally Dominick's job so, my understanding is that like
others, my name will be on one of his lines.
Thanks for your quick response and my love for refpolicy never change.
Thanks.
2014-03-14 23:55 GMT+09:00 Dominick Grift <[email protected]>:
> On Fri, 2014-03-14 at 10:49 -0400, Christopher J. PeBenito wrote:
> > On 03/14/2014 10:29 AM, Shintaro Fujiwara wrote:
> > > I thought my patch was merged but my name was not in the Changelog in
> the latest version.
> > >
>
> > I see that Dominick merged a patch from you that fixed a typo in
> ksmtuned_admin(); is this the patch you are referring to?
> >
>
> Yes that is probably the one, sorry about that.
>
> I was not a git formatted patch, and there was another typo. I did not
> merge that patch as is.
>
>
--
?????????????????????????
http://heavymetalhardrock.no-ip.info/ <http://www.heavymetalhardrock.tk/>
???????????SELinux??????????????
http://sourceforge.net/projects/segatex/
CMS?PHP?PostgreSQL???????????
http://sourceforge.net/projects/webon/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://oss.tresys.com/pipermail/refpolicy/attachments/20140315/a55827d3/attachment-0001.html
I found my name in contrib/Changelog on line 52.
I was forgetting and that's satisfiying.
Thanks!
2014-03-15 0:06 GMT+09:00 Shintaro Fujiwara <[email protected]>:
> I understand what you say and really appreciate Dominick's job.
> I am not so much talented guy and I found that miss-typed thing just
> making my segatex.
> The shell script I wrote found an minor error and I was glad that I found
> it and I had an former experience that I found my name on Changelog, so I
> was expecting that I could be in there again.
>
> I think it's totally Dominick's job so, my understanding is that like
> others, my name will be on one of his lines.
>
> Thanks for your quick response and my love for refpolicy never change.
>
> Thanks.
>
>
> 2014-03-14 23:55 GMT+09:00 Dominick Grift <[email protected]>:
>
> On Fri, 2014-03-14 at 10:49 -0400, Christopher J. PeBenito wrote:
>> > On 03/14/2014 10:29 AM, Shintaro Fujiwara wrote:
>> > > I thought my patch was merged but my name was not in the Changelog in
>> the latest version.
>> > >
>>
>> > I see that Dominick merged a patch from you that fixed a typo in
>> ksmtuned_admin(); is this the patch you are referring to?
>> >
>>
>> Yes that is probably the one, sorry about that.
>>
>> I was not a git formatted patch, and there was another typo. I did not
>> merge that patch as is.
>>
>>
>
>
> --
> ?????????????????????????
> http://heavymetalhardrock.no-ip.info/ <http://www.heavymetalhardrock.tk/>
>
> ???????????SELinux??????????????
> http://sourceforge.net/projects/segatex/
>
> CMS?PHP?PostgreSQL???????????
> http://sourceforge.net/projects/webon/
>
--
?????????????????????????
http://heavymetalhardrock.no-ip.info/ <http://www.heavymetalhardrock.tk/>
???????????SELinux??????????????
http://sourceforge.net/projects/segatex/
CMS?PHP?PostgreSQL???????????
http://sourceforge.net/projects/webon/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://oss.tresys.com/pipermail/refpolicy/attachments/20140315/87e9e814/attachment.html