2020-12-21 18:39:35

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH v2 0/2] ath10k: Fixes during subsystem recovery

Rakesh Pillai <[email protected]> writes:

> This patch series includes some fixes when the device
> is in recovery mode, i.e. when the firmware goes down.
>
> - Pausing TX queues when FW goes down
> - Removed unwanted/extra error logging in pkt TX path
> - Skipping wait for FW response for delete cmds
> - Handling the -ESHUTDOWN error code in case of SSR.
>
> Rakesh Pillai (2):
> ath10k: Pause the tx queues when firmware is down
> ath10k: Skip wait for delete response if firmware is down

This has been tested only on WCN3990. How do I know that this doesn't
break other hardware families?

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


2021-01-15 13:27:42

by Rakesh Pillai

[permalink] [raw]
Subject: RE: [PATCH v2 0/2] ath10k: Fixes during subsystem recovery


> -----Original Message-----
> From: Kalle Valo <[email protected]>
> Sent: Tuesday, December 22, 2020 12:07 AM
> To: Rakesh Pillai <[email protected]>
> Cc: [email protected]; [email protected]; linux-
> [email protected]
> Subject: Re: [PATCH v2 0/2] ath10k: Fixes during subsystem recovery
>
> Rakesh Pillai <[email protected]> writes:
>
> > This patch series includes some fixes when the device
> > is in recovery mode, i.e. when the firmware goes down.
> >
> > - Pausing TX queues when FW goes down
> > - Removed unwanted/extra error logging in pkt TX path
> > - Skipping wait for FW response for delete cmds
> > - Handling the -ESHUTDOWN error code in case of SSR.
> >
> > Rakesh Pillai (2):
> > ath10k: Pause the tx queues when firmware is down
> > ath10k: Skip wait for delete response if firmware is down
>
> This has been tested only on WCN3990. How do I know that this doesn't
> break other hardware families?

" ath10k: Pause the tx queues when firmware is down"
This is done only for SNOC (wcn3990) target and does not affect other
targets.

" ath10k: Skip wait for delete response if firmware is down"
The skip for wmi responses is done based on the flag
"ATH10K_FLAG_CRASH_FLUSH", which is generic for all targets.
Since if the FW is down, there wont be any response from the FW for any
target.

>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingp
> atches