2021-12-02 19:36:06

by Lorenzo Bianconi

[permalink] [raw]
Subject: [PATCH] mt76: mt7663: disable 4addr capability

4addr is not supported by the driver/firmware yet

Signed-off-by: Lorenzo Bianconi <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt7615/init.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/init.c b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
index 47f23ac905a3..52182ab6d240 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/init.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
@@ -378,6 +378,7 @@ mt7615_init_wiphy(struct ieee80211_hw *hw)
if (is_mt7663(&phy->dev->mt76)) {
wiphy->iface_combinations = if_comb;
wiphy->n_iface_combinations = ARRAY_SIZE(if_comb);
+ wiphy->flags &= ~WIPHY_FLAG_4ADDR_STATION;
} else {
wiphy->iface_combinations = if_comb_radar;
wiphy->n_iface_combinations = ARRAY_SIZE(if_comb_radar);
--
2.31.1



2021-12-03 08:32:13

by Felix Fietkau

[permalink] [raw]
Subject: Re: [PATCH] mt76: mt7663: disable 4addr capability


On 2021-12-02 20:35, Lorenzo Bianconi wrote:
> 4addr is not supported by the driver/firmware yet
>
> Signed-off-by: Lorenzo Bianconi <[email protected]>
> ---
> drivers/net/wireless/mediatek/mt76/mt7615/init.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/init.c b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
> index 47f23ac905a3..52182ab6d240 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7615/init.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
> @@ -378,6 +378,7 @@ mt7615_init_wiphy(struct ieee80211_hw *hw)
> if (is_mt7663(&phy->dev->mt76)) {
> wiphy->iface_combinations = if_comb;
> wiphy->n_iface_combinations = ARRAY_SIZE(if_comb);
> + wiphy->flags &= ~WIPHY_FLAG_4ADDR_STATION;
Shouldn't this be done for the offload firmware only?

- Felix

2021-12-03 10:07:22

by Lorenzo Bianconi

[permalink] [raw]
Subject: Re: [PATCH] mt76: mt7663: disable 4addr capability

>
> On 2021-12-02 20:35, Lorenzo Bianconi wrote:
> > 4addr is not supported by the driver/firmware yet
> >
> > Signed-off-by: Lorenzo Bianconi <[email protected]>
> > ---
> > drivers/net/wireless/mediatek/mt76/mt7615/init.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/init.c b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
> > index 47f23ac905a3..52182ab6d240 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt7615/init.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
> > @@ -378,6 +378,7 @@ mt7615_init_wiphy(struct ieee80211_hw *hw)
> > if (is_mt7663(&phy->dev->mt76)) {
> > wiphy->iface_combinations = if_comb;
> > wiphy->n_iface_combinations = ARRAY_SIZE(if_comb);
> > + wiphy->flags &= ~WIPHY_FLAG_4ADDR_STATION;
> Shouldn't this be done for the offload firmware only?
>
> - Felix
ack, right, I did not think about this combination. I tested with non-offload
fw and it works. I will post v2 to fix it.

Regards,
Lorenzo

Attachments:
(No filename) (1.00 kB)
 signature.asc (228.00 B)
 Download all attachments