2022-02-18 15:02:37

by Jérôme Pouiller

[permalink] [raw]
Subject: Re: [PATCH] staging: wfx: fix scan with WFM200 and WW regulation

Hello Riccardo,


On Friday 18 February 2022 14:53:35 CET Riccardo Ferrazzo wrote:
>
> Signed-off-by: Riccardo Ferrazzo <[email protected]>
>
>
> Sorry for the footer it is added automatically
>

Your mail has probably not been received by everyone since you sent it
in html[1] (try also to avoid top-posting).

Nevertheless, Greg, is it sufficient for you?

[1]: https://useplaintext.email/

> On Friday 18 February 2022 12:00:54 CET Greg Kroah-Hartman wrote:
> > On Fri, Feb 18, 2022 at 11:57:47AM +0100, J?r?me Pouiller wrote:
> > > On Friday 18 February 2022 11:53:58 CET Jerome Pouiller wrote:
> > > > From: Riccardo Ferrazzo <[email protected]>
> > > >
> > > > Some variants of the WF200 disallow active scan on channel 12 and 13.
> > > > For these parts, the channels 12 and 13 are marked IEEE80211_CHAN_NO_IR.
> > > >
> > > > However, the beacon hint procedure was removing the flag
> > > > IEEE80211_CHAN_NO_IR from channels where a BSS is discovered. This was
> > > > making subsequent scans to fail because the driver was trying active
> > > > scans on prohibited channels.
> > > >
> > > > Signed-off-by: J?r?me Pouiller <[email protected]>
> > >
> > > I forgot to mention I have reviewed on this patch:
> > >
> > > Reviewed-by: J?r?me Pouiller <[email protected]>
> >
> > Reviwed-by is implied with signed-off-by.
> >
> > But what happened to the signed-off-by from the author of this change?
>
> The author hasn't used format-patch to transmit this patch.
>
> Riccardo, can you reply to this mail with the mention "Signed-off-by:
> Your name <[email protected]>"? It certifies that you wrote it or
> otherwise have the right to pass it on as an open-source patch[1].
>
>
> [1] https://urlsand.esvalabs.com/?u=https%3A%2F%2Fwww.kernel.org%2Fdoc%2Fhtml%2Fv4.17%2Fprocess%2Fsubmitting-patches.html%23sign-your-work-the-developer-s-certificate-of-origin&e=09733f94&h=e09f2efa&f=y&p=n<https://urldefense.com/v3/__https://urlsand.esvalabs.com/?u=https*3A*2F*2Fwww.kernel.org*2Fdoc*2Fhtml*2Fv4.17*2Fprocess*2Fsubmitting-patches.html*23sign-your-work-the-developer-s-certificate-of-origin&e=09733f94&h=e09f2efa&f=y&p=n__;JSUlJSUlJSUl!!N30Cs7Jr!GRgB_JlhZF2XzaDEB1ZDnSbLiMmD8XdrmC_uqyLoczR5e05vvMlDCgyKlEu3XyI3PdJK$>
>
> Thank you,
>
> --
> J?r?me Pouiller
>
>
>


--
J?r?me Pouiller



2022-02-18 15:59:43

by Riccardo Ferrazzo

[permalink] [raw]
Subject: Re: [PATCH] staging: wfx: fix scan with WFM200 and WW regulation

>Da: Jérôme Pouiller <[email protected]>
>Inviato: venerdì 18 febbraio 2022 15:04
>A: Greg Kroah-Hartman; Riccardo Ferrazzo
>Cc: [email protected]; [email protected]; Kalle Valo; [email protected]; [email protected]; David S . Miller
>Oggetto: Re: [PATCH] staging: wfx: fix scan with WFM200 and WW regulation
>
>Hello Riccardo,
>
>
>On Friday 18 February 2022 14:53:35 CET Riccardo Ferrazzo wrote:
>>
>> Signed-off-by: Riccardo Ferrazzo <[email protected]>
>>
>>
>> Sorry for the footer it is added automatically
>>
>
>Your mail has probably not been received by everyone since you sent it
>in html[1] (try also to avoid top-posting).
>
>Nevertheless, Greg, is it sufficient for you?
>
>[1]: https://urlsand.esvalabs.com/?u=https%3A%2F%2Fuseplaintext.email%2F&e=09733f94&h=1ec5571e&f=y&p=n
>
>> On Friday 18 February 2022 12:00:54 CET Greg Kroah-Hartman wrote:
>> > On Fri, Feb 18, 2022 at 11:57:47AM +0100, Jérôme Pouiller wrote:
>> > > On Friday 18 February 2022 11:53:58 CET Jerome Pouiller wrote:
>> > >

Riccardo Ferrazzo
R&D Software Designer
[email protected]
CAME S.p.A.

> From: Riccardo Ferrazzo <[email protected]>
>> > > >
>> > > > Some variants of the WF200 disallow active scan on channel 12 and 13.
>> > > > For these parts, the channels 12 and 13 are marked IEEE80211_CHAN_NO_IR.
>> > > >
>> > > > However, the beacon hint procedure was removing the flag
>> > > > IEEE80211_CHAN_NO_IR from channels where a BSS is discovered. This was
>> > > > making subsequent scans to fail because the driver was trying active
>> > > > scans on prohibited channels.
>> > > >
>> > > > Signed-off-by: Jérôme Pouiller <[email protected]>
>> > >
>> > > I forgot to mention I have reviewed on this patch:
>> > >
>> > > Reviewed-by: Jérôme Pouiller <[email protected]>
>> >
>> > Reviwed-by is implied with signed-off-by.
>> >
>> > But what happened to the signed-off-by from the author of this change?
>>
>> The author hasn't used format-patch to transmit this patch.
>>
>> Riccardo, can you reply to this mail with the mention "Signed-off-by:
>> Your name <[email protected]>"? It certifies that you wrote it or
>> otherwise have the right to pass it on as an open-source patch[1].
>>
>>
>> [1] https://urlsand.esvalabs.com/?u=https%3A%2F%2Fwww.kernel.org%2Fdoc%2Fhtml%2Fv4.17%2Fprocess%2Fsubmitting-patches.html%23sign-your-work-the-developer-s-certificate-of-origin&e=09733f94&h=e09f2efa&f=y&p=n<https://urldefense.com/v3/__https://urlsand.esvalabs.com/?u=https*3A*2F*2Fwww.kernel.org*2Fdoc*2Fhtml*2Fv4.17*2Fprocess*2Fsubmitting-patches.html*23sign-your-work-the-developer-s-certificate-of-origin&e=09733f94&h=e09f2efa&f=y&p=n__;JSUlJSUlJSUl!!N30Cs7Jr!GRgB_JlhZF2XzaDEB1ZDnSbLiMmD8XdrmC_uqyLoczR5e05vvMlDCgyKlEu3XyI3PdJK$>
>>
>> Thank you,
>>
>> --
>> Jérôme Pouiller
>>
>>
>>
>
>--
>Jérôme Pouiller

Might look better now
Signed-off-by: Riccardo Ferrazzo <[email protected]>