2019-11-25 13:13:27

by Govind Singh

Subject: [PATCH] ath10k: move non-fatal warn logs to dbg level

During driver load below warn logs are printed in the console if
firmware doesn't support some optional HTC services, ex:pktlog.
It is likely some older fw version may not support PKTLOG HTC
service as legacy fw uses HTC DATA service for pktlog.
Move this log to debug level to remove un-necessary warn message
on console.

htc.c:803: ath10k_warn(ar, "unsupported HTC service id: %d\n",
htc.c:881: ath10k_warn(ar, "unsupported HTC service id: %d\n",

Signed-off-by: Govind Singh <[email protected]>
---
drivers/net/wireless/ath/ath10k/htc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/htc.c b/drivers/net/wireless/ath/ath10k/htc.c
index 28daed5981a1..367b762632d1 100644
--- a/drivers/net/wireless/ath/ath10k/htc.c
+++ b/drivers/net/wireless/ath/ath10k/htc.c
@@ -809,8 +809,8 @@ int ath10k_htc_connect_service(struct ath10k_htc *htc,
&ep->ul_pipe_id,
&ep->dl_pipe_id);
if (status) {
- ath10k_warn(ar, "unsupported HTC service id: %d\n",
- ep->service_id);
+ ath10k_dbg(ar, ATH10K_DBG_BOOT, "unsupported HTC service id: %d\n",
+ ep->service_id);
return status;
}

@@ -887,8 +887,8 @@ static bool ath10k_htc_pktlog_svc_supported(struct ath10k *ar)
&ul_pipe_id,
&dl_pipe_id);
if (status) {
- ath10k_warn(ar, "unsupported HTC service id: %d\n",
- ATH10K_HTC_SVC_ID_HTT_LOG_MSG);
+ ath10k_dbg(ar, ATH10K_DBG_BOOT, "unsupported HTC pktlog service id: %d\n",
+ ATH10K_HTC_SVC_ID_HTT_LOG_MSG);

return false;
}
--
2.22.0

2019-11-27 15:51:43

by Kalle Valo

Subject: Re: [PATCH] ath10k: move non-fatal warn logs to dbg level

Govind Singh <[email protected]> wrote:

> During driver load below warn logs are printed in the console if
> firmware doesn't support some optional HTC services, ex:pktlog.
> It is likely some older fw version may not support PKTLOG HTC
> service as legacy fw uses HTC DATA service for pktlog.
> Move this log to debug level to remove un-necessary warn message
> on console.
>
> htc.c:803: ath10k_warn(ar, "unsupported HTC service id: %d\n",
> htc.c:881: ath10k_warn(ar, "unsupported HTC service id: %d\n",
>
> Signed-off-by: Govind Singh <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

ef39ac1b0d9f ath10k: move non-fatal warn logs to dbg level

--
https://patchwork.kernel.org/patch/11260371/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches