2019-11-24 14:42:20

by Christian Lamparter

Subject: [PATCH] ath9k: use iowrite32 over __raw_writel

This patch changes the ath9k_pci_owl_loader to use the
same iowrite32 memory accessor that ath9k_pci is using
to communicate with the PCI(e) chip.

This will fix endian issues that came up during testing
with loaned AVM Fritz!Box 7360 (Lantiq MIPS SoCs + AR9287).

Fixes: 5a4f2040fd07 ("ath9k: add loader for AR92XX (and older) pci(e)")
Signed-off-by: Christian Lamparter <[email protected]>
---
drivers/net/wireless/ath/ath9k/ath9k_pci_owl_loader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath9k/ath9k_pci_owl_loader.c b/drivers/net/wireless/ath/ath9k/ath9k_pci_owl_loader.c
index 956fa7828d0c..56d1a7764b9f 100644
--- a/drivers/net/wireless/ath/ath9k/ath9k_pci_owl_loader.c
+++ b/drivers/net/wireless/ath/ath9k/ath9k_pci_owl_loader.c
@@ -83,7 +83,7 @@ static int ath9k_pci_fixup(struct pci_dev *pdev, const u16 *cal_data,
val = swahb32(val);
}

- __raw_writel(val, mem + reg);
+ iowrite32(val, mem + reg);
usleep_range(100, 120);
}

--
2.24.0

2019-11-24 14:52:04

by Kalle Valo

Subject: Re: [PATCH] ath9k: use iowrite32 over __raw_writel

Christian Lamparter <[email protected]> writes:

> This patch changes the ath9k_pci_owl_loader to use the
> same iowrite32 memory accessor that ath9k_pci is using
> to communicate with the PCI(e) chip.
>
> This will fix endian issues that came up during testing
> with loaned AVM Fritz!Box 7360 (Lantiq MIPS SoCs + AR9287).
>
> Fixes: 5a4f2040fd07 ("ath9k: add loader for AR92XX (and older) pci(e)")
> Signed-off-by: Christian Lamparter <[email protected]>

I'll queue this to v5.5.

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2019-11-28 08:21:49

by Kalle Valo

Subject: Re: [PATCH] ath9k: use iowrite32 over __raw_writel

Christian Lamparter <[email protected]> wrote:

> This patch changes the ath9k_pci_owl_loader to use the
> same iowrite32 memory accessor that ath9k_pci is using
> to communicate with the PCI(e) chip.
>
> This will fix endian issues that came up during testing
> with loaned AVM Fritz!Box 7360 (Lantiq MIPS SoCs + AR9287).
>
> Fixes: 5a4f2040fd07 ("ath9k: add loader for AR92XX (and older) pci(e)")
> Signed-off-by: Christian Lamparter <[email protected]>

Patch applied to wireless-drivers.git, thanks.

22d0d5ae7a08 ath9k: use iowrite32 over __raw_writel

--
https://patchwork.kernel.org/patch/11259213/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches