2020-09-08 10:06:05

by Anilkumar Kolli

Subject: [PATCH] ath11k: remove calling ath11k_init_hw_params() second time

During probe ath11k_init_hw_params() is called from ath11k_core_pre_init()
and is not needed agian in ath11k_core_init().

Tested on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-00009-QCAHKSWPL_SILICONZ-1

Fixes: 1ff8ed786d5d (ath11k: use remoteproc only with AHB devices)
Signed-off-by: Anilkumar Kolli <[email protected]>
---
drivers/net/wireless/ath/ath11k/core.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
index 648a697e414a..03e922111cd6 100644
--- a/drivers/net/wireless/ath/ath11k/core.c
+++ b/drivers/net/wireless/ath/ath11k/core.c
@@ -849,12 +849,6 @@ int ath11k_core_init(struct ath11k_base *ab)
return ret;
}

- ret = ath11k_init_hw_params(ab);
- if (ret) {
- ath11k_err(ab, "failed to get hw params %d\n", ret);
- return ret;
- }
-
ret = ath11k_core_soc_create(ab);
if (ret) {
ath11k_err(ab, "failed to create soc core: %d\n", ret);
--
2.7.4

2020-09-11 10:00:20

by Kalle Valo

Subject: Re: [PATCH] ath11k: remove calling ath11k_init_hw_params() second time

Anilkumar Kolli <[email protected]> wrote:

> During probe ath11k_init_hw_params() is called from ath11k_core_pre_init()
> and is not needed agian in ath11k_core_init().
>
> Tested on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-00009-QCAHKSWPL_SILICONZ-1
>
> Fixes: 1ff8ed786d5d (ath11k: use remoteproc only with AHB devices)
> Signed-off-by: Anilkumar Kolli <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

a9d9e03858ad ath11k: remove calling ath11k_init_hw_params() second time

--
https://patchwork.kernel.org/patch/11763091/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches