2023-11-17 05:32:05

by Rafał Miłecki

[permalink] [raw]
Subject: mt76 DT binding: undocumented interrupts

Hi,

I noticed that Wi-Fi on mt7986 has 4 interrupts instead of 1. See:
arch/arm64/boot/dts/mediatek/mt7986a.dtsi
300218b0503d ("arm64: dts: mt7986: add built-in Wi-Fi device nodes")

Those interrupts seem unused by Linux's mt76 driver and are
undocumented in mediatek,mt76.yaml.

Can someone explain what those interrupts are, or just send DT binding
update patch, please? I'd like to get DTS matching DT binding and
passing dtbs_check validation.

--
Rafał


2023-11-21 12:47:27

by Kalle Valo

[permalink] [raw]
Subject: Re: mt76 DT binding: undocumented interrupts

Rafał Miłecki <[email protected]> writes:

> I noticed that Wi-Fi on mt7986 has 4 interrupts instead of 1. See:
> arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> 300218b0503d ("arm64: dts: mt7986: add built-in Wi-Fi device nodes")
>
> Those interrupts seem unused by Linux's mt76 driver and are
> undocumented in mediatek,mt76.yaml.
>
> Can someone explain what those interrupts are, or just send DT binding
> update patch, please? I'd like to get DTS matching DT binding and
> passing dtbs_check validation.

Is anyone looking at this? Peter Chiu, why did you add undocumented
interrupts?

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2023-11-22 03:32:20

by Peter Chiu

[permalink] [raw]
Subject: Re: mt76 DT binding: undocumented interrupts

On Tue, 2023-11-21 at 14:46 +0200, Kalle Valo wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> Rafał Miłecki <[email protected]> writes:
>
> > I noticed that Wi-Fi on mt7986 has 4 interrupts instead of 1. See:
> > arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> > 300218b0503d ("arm64: dts: mt7986: add built-in Wi-Fi device
> nodes")
> >
> > Those interrupts seem unused by Linux's mt76 driver and are
> > undocumented in mediatek,mt76.yaml.
> >
> > Can someone explain what those interrupts are, or just send DT
> binding
> > update patch, please? I'd like to get DTS matching DT binding and
> > passing dtbs_check validation.
>
> Is anyone looking at this? Peter Chiu, why did you add undocumented
> interrupts?
>

Hi Kalle and Rafał,

The DT binding was not updated and we will send a patch to fix it.
Thanks for your reminder.

Best regards,
Peter Chiu