2023-12-21 03:27:03

by Peter Chiu

Subject: [PATCH v4] dt-bindings: net: wireless: mt76: add interrupts description for MT7986

The mt7986 can support four interrupts to distribute the interrupts
to different CPUs.

Signed-off-by: Peter Chiu <[email protected]>
---
v2: Change to use description instead of using items.
v3: Change to use items and set different minItems for mediatek,mt7986-wmac
v4: Move allOf after required and remove duplicated blank line.
---
.../bindings/net/wireless/mediatek,mt76.yaml | 32 ++++++++++++++++---
1 file changed, 27 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
index 252207adbc54..0c6835db397f 100644
--- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
@@ -19,9 +19,6 @@ description: |
Alternatively, it can specify the wireless part of the MT7628/MT7688
or MT7622/MT7986 SoC.

-allOf:
- - $ref: ieee80211.yaml#
-
properties:
compatible:
enum:
@@ -38,7 +35,12 @@ properties:
MT7986 should contain 3 regions consys, dcm, and sku, in this order.

interrupts:
- maxItems: 1
+ minItems: 1
+ items:
+ - description: major interrupt for rings
+ - description: additional interrupt for ring 19
+ - description: additional interrupt for ring 4
+ - description: additional interrupt for ring 5

power-domains:
maxItems: 1
@@ -217,6 +219,23 @@ required:
- compatible
- reg

+allOf:
+ - $ref: ieee80211.yaml#
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - mediatek,mt7986-wmac
+ then:
+ properties:
+ interrupts:
+ minItems: 4
+ else:
+ properties:
+ interrupts:
+ maxItems: 1
+
unevaluatedProperties: false

examples:
@@ -293,7 +312,10 @@ examples:
reg = <0x18000000 0x1000000>,
<0x10003000 0x1000>,
<0x11d10000 0x1000>;
- interrupts = <GIC_SPI 213 IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <GIC_SPI 213 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 214 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 216 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&topckgen 50>,
<&topckgen 62>;
clock-names = "mcu", "ap2conn";
--
2.18.0

2023-12-21 08:20:05

by Krzysztof Kozlowski

Subject: Re: [PATCH v4] dt-bindings: net: wireless: mt76: add interrupts description for MT7986

On 21/12/2023 04:26, Peter Chiu wrote:
> The mt7986 can support four interrupts to distribute the interrupts
> to different CPUs.
>
> Signed-off-by: Peter Chiu <[email protected]>
> ---
> v2: Change to use description instead of using items.
> v3: Change to use items and set different minItems for mediatek,mt7986-wmac
> v4: Move allOf after required and remove duplicated blank line.

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2024-02-12 07:22:41

by Rafał Miłecki

Subject: Re: [PATCH v4] dt-bindings: net: wireless: mt76: add interrupts description for MT7986

On 21.12.2023 04:26, Peter Chiu wrote:
> The mt7986 can support four interrupts to distribute the interrupts
> to different CPUs.

Can we have this patch picked up, please? Felix? Kalle?

2024-02-12 08:51:19

by AngeloGioacchino Del Regno

Subject: Re: [PATCH v4] dt-bindings: net: wireless: mt76: add interrupts description for MT7986

Il 21/12/23 04:26, Peter Chiu ha scritto:
> The mt7986 can support four interrupts to distribute the interrupts
> to different CPUs.
>
> Signed-off-by: Peter Chiu <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>