2017-09-19 20:40:23

by Colin King

Subject: [PATCH] ath9k: make const array reg_hole_list static, reduces object code size

From: Colin Ian King <[email protected]>

Don't populate the read-only array reg_hole_list on the stack, instead make
it static. Makes the object code smaller by over 200 bytes:

Before:
text data bss dec hex filename
57518 15248 0 72766 11c3e debug.o

After:
text data bss dec hex filename
57218 15344 0 72562 11b72 debug.o

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/wireless/ath/ath9k/debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath9k/debug.c b/drivers/net/wireless/ath/ath9k/debug.c
index 01fa30117288..5a0a05abd51a 100644
--- a/drivers/net/wireless/ath/ath9k/debug.c
+++ b/drivers/net/wireless/ath/ath9k/debug.c
@@ -916,7 +916,7 @@ static int open_file_regdump(struct inode *inode, struct file *file)
u8 *buf;
int i, j = 0;
unsigned long num_regs, regdump_len, max_reg_offset;
- const struct reg_hole {
+ static const struct reg_hole {
u32 start;
u32 end;
} reg_hole_list[] = {
--
2.14.1

2017-10-04 09:09:25

by Kalle Valo

Subject: Re: ath9k: make const array reg_hole_list static, reduces object code size

Colin Ian King <[email protected]> wrote:

> Don't populate the read-only array reg_hole_list on the stack, instead make
> it static. Makes the object code smaller by over 200 bytes:
>
> Before:
> text data bss dec hex filename
> 57518 15248 0 72766 11c3e debug.o
>
> After:
> text data bss dec hex filename
> 57218 15344 0 72562 11b72 debug.o
>
> Signed-off-by: Colin Ian King <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

eba0f28473b2 ath9k: make const array reg_hole_list static, reduces object code size

--
https://patchwork.kernel.org/patch/9960183/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches