2022-12-06 08:13:18

by Veerendranath Jakkam

Subject: [PATCH 3/3] wifi: cfg80211: Use MLD address to indicate MLD STA disconnection

Use station's MLD address to report disconnection of MLD station.
Updated documentation in multiple places to indicate the same.

Signed-off-by: Veerendranath Jakkam <[email protected]>
---
include/net/cfg80211.h | 4 ++--
include/uapi/linux/nl80211.h | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
index 36cecfa217f1..eeb9a43c77df 100644
--- a/include/net/cfg80211.h
+++ b/include/net/cfg80211.h
@@ -7812,7 +7812,7 @@ void cfg80211_new_sta(struct net_device *dev, const u8 *mac_addr,
/**
* cfg80211_del_sta_sinfo - notify userspace about deletion of a station
* @dev: the netdev
- * @mac_addr: the station's address
+ * @mac_addr: the station's address. For MLD station, MLD address is used.
* @sinfo: the station information/statistics
* @gfp: allocation flags
*/
@@ -7823,7 +7823,7 @@ void cfg80211_del_sta_sinfo(struct net_device *dev, const u8 *mac_addr,
* cfg80211_del_sta - notify userspace about deletion of a station
*
* @dev: the netdev
- * @mac_addr: the station's address
+ * @mac_addr: the station's address. For MLD station, MLD address is used.
* @gfp: allocation flags
*/
static inline void cfg80211_del_sta(struct net_device *dev,
diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
index c14a91bbca7c..e1d54ebc1dcb 100644
--- a/include/uapi/linux/nl80211.h
+++ b/include/uapi/linux/nl80211.h
@@ -424,7 +424,8 @@
* interface identified by %NL80211_ATTR_IFINDEX.
* @NL80211_CMD_DEL_STATION: Remove a station identified by %NL80211_ATTR_MAC
* or, if no MAC address given, all stations, on the interface identified
- * by %NL80211_ATTR_IFINDEX. %NL80211_ATTR_MGMT_SUBTYPE and
+ * by %NL80211_ATTR_IFINDEX. For MLD station, MLD address is used in
+ * %NL80211_ATTR_MAC. %NL80211_ATTR_MGMT_SUBTYPE and
* %NL80211_ATTR_REASON_CODE can optionally be used to specify which type
* of disconnection indication should be sent to the station
* (Deauthentication or Disassociation frame and reason code for that
--
2.25.1

2023-01-18 15:46:41

by Johannes Berg

Subject: Re: [PATCH 3/3] wifi: cfg80211: Use MLD address to indicate MLD STA disconnection

On Tue, 2022-12-06 at 13:32 +0530, Veerendranath Jakkam wrote:
> Use station's MLD address to report disconnection of MLD station.
> Updated documentation in multiple places to indicate the same.
>

Applied, but in the future please write commit messages in imperative:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_messages

johannes