2015-12-01 19:14:18

by Grumbach, Emmanuel

[permalink] [raw]
Subject: Re: [PATCH 24/41] iwlwifi: mvm: move fw-dbg code to separate file



On 12/01/2015 08:53 PM, Kalle Valo wrote:
> Emmanuel Grumbach <[email protected]> writes:
>
>> From: Golan Ben-Ami <[email protected]>
>>
>> The fw debug functionality is big enough to warrant
>> a separate file. Move existing related functions to the new file.
>>
>> Signed-off-by: Golan Ben-Ami <[email protected]>
>> Signed-off-by: Emmanuel Grumbach <[email protected]>
> [...]
>
>> intc-scripts/publishable-files | 203 ++++++
> Added by accident?
>
Indeed... Thanks for catching this...
Will re-spin...


2015-12-01 19:26:22

by Emmanuel Grumbach

[permalink] [raw]
Subject: Re: [PATCH 24/41] iwlwifi: mvm: move fw-dbg code to separate file

On Tue, Dec 1, 2015 at 9:14 PM, Grumbach, Emmanuel
<[email protected]> wrote:
>
>
> On 12/01/2015 08:53 PM, Kalle Valo wrote:
>> Emmanuel Grumbach <[email protected]> writes:
>>
>>> From: Golan Ben-Ami <[email protected]>
>>>
>>> The fw debug functionality is big enough to warrant
>>> a separate file. Move existing related functions to the new file.
>>>
>>> Signed-off-by: Golan Ben-Ami <[email protected]>
>>> Signed-off-by: Emmanuel Grumbach <[email protected]>
>> [...]
>>
>>> intc-scripts/publishable-files | 203 ++++++
>> Added by accident?
>>
Somehow this file didn't appear in the pull request message. I would
have caught there I believe.

> Indeed... Thanks for catching this...
> Will re-spin...

I pushed -f the tree with the same tag. Should be fine now. Thanks again.

2015-12-01 19:29:08

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH 24/41] iwlwifi: mvm: move fw-dbg code to separate file

Emmanuel Grumbach <[email protected]> writes:

> On Tue, Dec 1, 2015 at 9:14 PM, Grumbach, Emmanuel
> <[email protected]> wrote:
>>
>>
>> On 12/01/2015 08:53 PM, Kalle Valo wrote:
>>> Emmanuel Grumbach <[email protected]> writes:
>>>
>>>> From: Golan Ben-Ami <[email protected]>
>>>>
>>>> The fw debug functionality is big enough to warrant
>>>> a separate file. Move existing related functions to the new file.
>>>>
>>>> Signed-off-by: Golan Ben-Ami <[email protected]>
>>>> Signed-off-by: Emmanuel Grumbach <[email protected]>
>>> [...]
>>>
>>>> intc-scripts/publishable-files | 203 ++++++
>>> Added by accident?
>>>
>
> Somehow this file didn't appear in the pull request message. I would
> have caught there I believe.

It wasn't visible in the pull request as a later patch removed the same
file.

--
Kalle Valo