Use is_zero_ether_addr() instead of ether_addr_equal()
to check if the ethernet address is all zeros.
Signed-off-by: Ruan Jinjie <[email protected]>
---
drivers/net/wireless/marvell/mwifiex/scan.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/scan.c b/drivers/net/wireless/marvell/mwifiex/scan.c
index 644b1e134b01..fb3105a76337 100644
--- a/drivers/net/wireless/marvell/mwifiex/scan.c
+++ b/drivers/net/wireless/marvell/mwifiex/scan.c
@@ -828,7 +828,6 @@ mwifiex_config_scan(struct mwifiex_private *priv,
u8 ssid_filter;
struct mwifiex_ie_types_htcap *ht_cap;
struct mwifiex_ie_types_bss_mode *bss_mode;
- const u8 zero_mac[6] = {0, 0, 0, 0, 0, 0};
/* The tlv_buf_len is calculated for each scan command. The TLVs added
in this routine will be preserved since the routine that sends the
@@ -966,7 +965,7 @@ mwifiex_config_scan(struct mwifiex_private *priv,
sizeof(struct mwifiex_ie_types_scan_chan_gap);
}
- if (!ether_addr_equal(user_scan_in->random_mac, zero_mac)) {
+ if (!is_zero_ether_addr(user_scan_in->random_mac)) {
random_mac_tlv = (void *)tlv_pos;
random_mac_tlv->header.type =
cpu_to_le16(TLV_TYPE_RANDOM_MAC);
--
2.34.1
On Tue, Aug 08, 2023 at 04:10:23PM +0800, Ruan Jinjie wrote:
> Use is_zero_ether_addr() instead of ether_addr_equal()
> to check if the ethernet address is all zeros.
>
> Signed-off-by: Ruan Jinjie <[email protected]>
Usually you should provide some explanation for a RESEND of a
seemingly-identical patch. Seemingly you just updated the address list?
Anyway, looks fine:
Acked-by: Brian Norris <[email protected]>
On 2023/8/9 4:13, Brian Norris wrote:
> On Tue, Aug 08, 2023 at 04:10:23PM +0800, Ruan Jinjie wrote:
>> Use is_zero_ether_addr() instead of ether_addr_equal()
>> to check if the ethernet address is all zeros.
>>
>> Signed-off-by: Ruan Jinjie <[email protected]>
>
> Usually you should provide some explanation for a RESEND of a
> seemingly-identical patch. Seemingly you just updated the address list?
Sorry, the git email tocmd has a problem, the original address lists
which parsed from get_maintainer.pl cmd is incomplete, so I resend it.
>
> Anyway, looks fine:
>
> Acked-by: Brian Norris <[email protected]>