2007-05-17 03:13:53

by Hong Liu

[permalink] [raw]
Subject: [patch] mac80211: fix memory leak when defrag fragments

We forget to free all the fragments when defraging them into one packet.

Signed-off-by: Hong Liu <[email protected]>

diff --git a/net/mac80211/ieee80211.c b/net/mac80211/ieee80211.c
index 873ccb0..ed86804 100644
--- a/net/mac80211/ieee80211.c
+++ b/net/mac80211/ieee80211.c
@@ -3412,8 +3412,10 @@ ieee80211_rx_h_defragment(struct ieee80211_txrx_data *rx)
return TXRX_DROP;
}
}
- while ((skb = __skb_dequeue(&entry->skb_list)))
+ while ((skb = __skb_dequeue(&entry->skb_list))) {
memcpy(skb_put(rx->skb, skb->len), skb->data, skb->len);
+ dev_kfree_skb(skb);
+ }

/* Complete frame has been reassembled - process it now */
rx->fragmented = 1;