> +config MAC80211_RCSIMPLE
> + bool "'simple' rate control algorithm (DEPRECATED)"
> + default n
> + depends on MAC80211
> + ---help---
I'm pretty sure just "help" is preferred style these days.
And I already said that I'd rather see a single patch that replaces
_SIMPLE with _PID.
I'd split up the patch series as follows:
1) API cleanup, including all rate control algorithms
2) PID replace SIMPLE
3..N) PID improvements
Although since this is all new code 2..N should probably be collapsed
into a single patch.
johannes
On Mon, 2007-12-17 at 12:52 +0100, Johannes Berg wrote:
> > +config MAC80211_RCSIMPLE
> > + bool "'simple' rate control algorithm (DEPRECATED)"
> > + default n
> > + depends on MAC80211
> > + ---help---
>
> I'm pretty sure just "help" is preferred style these days.
>
> And I already said that I'd rather see a single patch that replaces
> _SIMPLE with _PID.
>
> I'd split up the patch series as follows:
> 1) API cleanup, including all rate control algorithms
> 2) PID replace SIMPLE
These two refer to stuff I'm happy with.
> 3..N) PID improvements
These are patches that IMHO need further testing. They extend the PID
controller concept in a non-standard way. Stefano says they help in some
situations.
>
> Although since this is all new code 2..N should probably be collapsed
> into a single patch.
See the comment above for why they're separate patches at the time of
writing this.
Mattias