LinuxLists.cc - Re: [patch 7/9] mac80211: Dump rc80211

2007-12-17 17:46:54

Subject: Re: [patch 7/9] mac80211: Dump rc80211_pid events to debugfs

> +#ifdef CONFIG_MAC80211_DEBUGFS
> +#include "rc80211_pid_debugfs.h"
> +#endif
> +#include "rc80211_pid.h"

Don't ifdef includes. Also, I think it's overkill to have two header
files for a single rate control algorithm, just use a single combined
one.

johannes

Attachments:

signature.asc (828.00 B)
This is a digitally signed message part

2007-12-17 21:09:15

by Mattias Nissler

[permalink] [raw]

Subject: Re: [patch 7/9] mac80211: Dump rc80211_pid events to debugfs

On Mon, 2007-12-17 at 12:57 +0100, Johannes Berg wrote:
> > +#ifdef CONFIG_MAC80211_DEBUGFS
> > +#include "rc80211_pid_debugfs.h"
> > +#endif
> > +#include "rc80211_pid.h"
>
> Don't ifdef includes. Also, I think it's overkill to have two header
> files for a single rate control algorithm, just use a single combined
> one.

Will do.

Mattias