2008-02-12 23:09:04

by Marcin Ślusarz

Subject: [PATCH] ipw2200: le*_add_cpu conversion

From: Marcin Slusarz <[email protected]>

replace all:
little_endian_variable = cpu_to_leX(leX_to_cpu(little_endian_variable) +
expression_in_cpu_byteorder);
with:
leX_add_cpu(&little_endian_variable, expression_in_cpu_byteorder);
generated with semantic patch

Signed-off-by: Marcin Slusarz <[email protected]>
Cc: Zhu Yi <[email protected]>
Cc: John W. Linville <[email protected]>
Cc: [email protected]
---
drivers/net/wireless/ipw2200.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ipw2200.c b/drivers/net/wireless/ipw2200.c
index 3e6ad7b..5d9854e 100644
--- a/drivers/net/wireless/ipw2200.c
+++ b/drivers/net/wireless/ipw2200.c
@@ -10326,9 +10326,7 @@ static int ipw_tx_skb(struct ipw_priv *priv, struct ieee80211_txb *txb,
remaining_bytes,
PCI_DMA_TODEVICE));

- tfd->u.data.num_chunks =
- cpu_to_le32(le32_to_cpu(tfd->u.data.num_chunks) +
- 1);
+ le32_add_cpu(&tfd->u.data.num_chunks, 1);
}
}

--
1.5.3.7

2008-02-13 16:55:49

by Reinette Chatre

Subject: RE: [PATCH] ipw2200: le*_add_cpu conversion

On Tuesday, February 12, 2008 3:06 PM,
[email protected] wrote:

> From: Marcin Slusarz <[email protected]>
>
> replace all:
> little_endian_variable =
> cpu_to_leX(leX_to_cpu(little_endian_variable) +
> expression_in_cpu_byteorder);
> with:
> leX_add_cpu(&little_endian_variable,
> expression_in_cpu_byteorder);
> generated with semantic patch
>
> Signed-off-by: Marcin Slusarz <[email protected]>
> Cc: Zhu Yi <[email protected]>
> Cc: John W. Linville <[email protected]>
> Cc: [email protected]
> ---
> drivers/net/wireless/ipw2200.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ipw2200.c
> b/drivers/net/wireless/ipw2200.c
> index 3e6ad7b..5d9854e 100644
> --- a/drivers/net/wireless/ipw2200.c
> +++ b/drivers/net/wireless/ipw2200.c
> @@ -10326,9 +10326,7 @@ static int ipw_tx_skb(struct ipw_priv
> *priv, struct ieee80211_txb *txb,
> remaining_bytes,
> PCI_DMA_TODEVICE));
>
> - tfd->u.data.num_chunks =
> -
> cpu_to_le32(le32_to_cpu(tfd->u.data.num_chunks) +
> - 1);
> + le32_add_cpu(&tfd->u.data.num_chunks, 1);
> }
> }
>
> --
> 1.5.3.7

Thanks!

Signed-off-by: Reinette Chatre <[email protected]>

Reinette