2008-02-22 07:46:18

by Masakazu Mokuno

Subject: [PATCH] PS3: gelic: Link the wireless net_device structure to the corresponding device structure

Link the net_device structure of the wireless part to the
corresponding device structure.

Without this, the sysfs node for this net_device would not have
'device' link.

Signed-off-by: Masakazu Mokuno <[email protected]>
---
drivers/net/ps3_gelic_wireless.c | 1 +
1 file changed, 1 insertion(+)

--- a/drivers/net/ps3_gelic_wireless.c
+++ b/drivers/net/ps3_gelic_wireless.c
@@ -2690,6 +2690,7 @@ int gelic_wl_driver_probe(struct gelic_c
return -ENOMEM;

/* setup net_device structure */
+ SET_NETDEV_DEV(netdev, &card->dev->core);
gelic_wl_setup_netdev_ops(netdev);

/* setup some of net_device and register it */

--
Masakazu MOKUNO

2008-02-22 14:14:31

by Dan Williams

Subject: Re: [PATCH] PS3: gelic: Link the wireless net_device structure to the corresponding device structure

On Fri, 2008-02-22 at 16:45 +0900, Masakazu Mokuno wrote:
> Link the net_device structure of the wireless part to the
> corresponding device structure.
>
> Without this, the sysfs node for this net_device would not have
> 'device' link.
>
> Signed-off-by: Masakazu Mokuno <[email protected]>

Hmm; I must have missed this in the review. But it does need to be
there, good catch.

Acked-by: Dan Williams <[email protected]>

> ---
> drivers/net/ps3_gelic_wireless.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/drivers/net/ps3_gelic_wireless.c
> +++ b/drivers/net/ps3_gelic_wireless.c
> @@ -2690,6 +2690,7 @@ int gelic_wl_driver_probe(struct gelic_c
> return -ENOMEM;
>
> /* setup net_device structure */
> + SET_NETDEV_DEV(netdev, &card->dev->core);
> gelic_wl_setup_netdev_ops(netdev);
>
> /* setup some of net_device and register it */
>