2008-03-25 15:29:59

by Johannes Berg

[permalink] [raw]
Subject: adm8211 crypto bug?

static int adm8211_tx(struct ieee80211_hw *dev, struct sk_buff *skb,
struct ieee80211_tx_control *control)

[...]
fc = le16_to_cpu(hdr->frame_control) & ~IEEE80211_FCTL_PROTECTED;
[...]
len = hdrlen + payload_len + FCS_LEN;
if (fc & IEEE80211_FCTL_PROTECTED)
len += 8;
[...]

johannes


Attachments:
signature.asc (828.00 B)
This is a digitally signed message part

2008-03-31 18:42:18

by Michael Wu

[permalink] [raw]
Subject: Re: adm8211 crypto bug?

On Tuesday 25 March 2008 09:42:38 Johannes Berg wrote:
> static int adm8211_tx(struct ieee80211_hw *dev, struct sk_buff *skb,
> struct ieee80211_tx_control *control)
>
> [...]
> fc = le16_to_cpu(hdr->frame_control) & ~IEEE80211_FCTL_PROTECTED;
> [...]
> len = hdrlen + payload_len + FCS_LEN;
> if (fc & IEEE80211_FCTL_PROTECTED)
> len += 8;
> [...]
>
Nope. It's just a cheap hack to disable hw crypto support. I was planning to
add hw crypto support back at some point so I just added the |&
~IEEE80211_FCTL_PROTECTED| part to disable it without removing the code.

-Michael Wu


Attachments:
(No filename) (642.00 B)
signature.asc (194.00 B)
This is a digitally signed message part.
Download all attachments