2008-04-01 14:14:30

by Michael Büsch

[permalink] [raw]
Subject: [PATCH] b43: Enable quantum cryptography support

This patch enables support for quantum cryptography on latest b43 devices.
The quantum cryptography algorithm is 100% backward compatible with the
standard CCMP algorithm, so no additional changes to the mac80211 stack
are needed. While staying compatible, it makes the unbreakable(!) WLAN connection
possible. Of course, that's only the case, if both ends use b43-qcrypto.
In the case where one STA uses legacy encryption, the card will automatically
detect this and switch back to plain old CCMP.

Signed-off-by: Michael Buesch <[email protected]>

---

John, please queue this patch for linux-3.6.26


Index: wireless-testing/drivers/net/wireless/b43/b43.h
===================================================================
--- wireless-testing.orig/drivers/net/wireless/b43/b43.h 2008-03-22 15:44:00.000000000 +0100
+++ wireless-testing/drivers/net/wireless/b43/b43.h 2008-04-01 15:53:40.000000000 +0200
@@ -270,6 +270,7 @@ enum {
#define B43_HF_ANTSELMODE 0x000200000000ULL /* Antenna selection mode (rev >= 13 only) */
#define B43_HF_MLADVW 0x001000000000ULL /* N PHY ML ADV workaround (rev >= 13 only) */
#define B43_HF_PR45960W 0x080000000000ULL /* PR 45960 workaround (rev >= 13 only) */
+#define B43_HF_QUANTUMCRYPT 0x100000000000ULL /* Enable quantum cryptography in firmware. */

/* MacFilter offsets. */
#define B43_MACFILTER_SELF 0x0000
@@ -439,6 +440,7 @@ enum {
B43_SEC_ALGO_AES,
B43_SEC_ALGO_WEP104,
B43_SEC_ALGO_AES_LEGACY,
+ B43_SEC_ALGO_QUANTUM,
};

struct b43_dmaring;
Index: wireless-testing/drivers/net/wireless/b43/main.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/b43/main.c 2008-03-27 17:11:38.000000000 +0100
+++ wireless-testing/drivers/net/wireless/b43/main.c 2008-04-01 15:53:41.000000000 +0200
@@ -3215,6 +3215,13 @@ static int b43_op_set_key(struct ieee802
break;
case ALG_CCMP:
algorithm = B43_SEC_ALGO_AES;
+ if (dev->dev->id.revision >= 20080401) {
+ /* Latest devices can do quantum cryptography
+ * to encrypt/decrypt the data stream.
+ * This is 100% backward compatible with the traditional
+ * CCMP algorithm. */
+ algorithm = B43_SEC_ALGO_QUANTUM;
+ }
break;
default:
B43_WARN_ON(1);
@@ -3254,6 +3261,10 @@ static int b43_op_set_key(struct ieee802
b43_hf_write(dev,
b43_hf_read(dev) & ~B43_HF_USEDEFKEYS);
}
+ if (algorithm == B43_SEC_ALGO_QUANTUM) {
+ b43_hf_write(dev, b43_hf_read(dev)
+ | B43_HF_QUANTUMCRYPT);
+ }
key->flags |= IEEE80211_KEY_FLAG_GENERATE_IV;
break;
case DISABLE_KEY: {

--
Greetings Michael.


2008-04-01 17:48:55

by Gábor Stefanik

[permalink] [raw]
Subject: Re: [PATCH] b43: Enable quantum cryptography support

Try the latest GCC 6 development version, that should work. (I tested
it on a Core 4 Hexadeca CPU, not sure if it will work on Core 3 Octos,
as it seems to use SSE6 instructions. Maybe DDR5 RAM is required,
too.)

On 4/1/08, [email protected] <[email protected]> wrote:
> I tried this patch against the 3.6 tree and I was unable to get it to
> compile.
> It kept saying my version of gcc is too old.
> Is it my SPROM?
>
> Ehud
> gcc version 5.1.2 20090401 (Red Hat 5.1.2-33)
>
> Michael Buesch wrote:
> > This patch enables support for quantum cryptography on latest b43 devices.
> > The quantum cryptography algorithm is 100% backward compatible with the
> > standard CCMP algorithm, so no additional changes to the mac80211 stack
> > are needed. While staying compatible, it makes the unbreakable(!) WLAN
> connection
> > possible. Of course, that's only the case, if both ends use b43-qcrypto.
> > In the case where one STA uses legacy encryption, the card will
> automatically
> > detect this and switch back to plain old CCMP.
> >
> > Signed-off-by: Michael Buesch <[email protected]>
> >
> > ---
> >
> > John, please queue this patch for linux-3.6.26
> >
> >
> > Index: wireless-testing/drivers/net/wireless/b43/b43.h
> > ===================================================================
> > --- wireless-testing.orig/drivers/net/wireless/b43/b43.h 2008-03-22
> 15:44:00.000000000 +0100
> > +++ wireless-testing/drivers/net/wireless/b43/b43.h 2008-04-01
> 15:53:40.000000000 +0200
> > @@ -270,6 +270,7 @@ enum {
> > #define B43_HF_ANTSELMODE 0x000200000000ULL /* Antenna selection mode
> (rev >= 13 only) */
> > #define B43_HF_MLADVW 0x001000000000ULL /* N PHY ML ADV workaround (rev
> >= 13 only) */
> > #define B43_HF_PR45960W 0x080000000000ULL /* PR 45960 workaround (rev >=
> 13 only) */
> > +#define B43_HF_QUANTUMCRYPT 0x100000000000ULL /* Enable quantum
> cryptography in firmware. */
> >
> > /* MacFilter offsets. */
> > #define B43_MACFILTER_SELF 0x0000
> > @@ -439,6 +440,7 @@ enum {
> > B43_SEC_ALGO_AES,
> > B43_SEC_ALGO_WEP104,
> > B43_SEC_ALGO_AES_LEGACY,
> > + B43_SEC_ALGO_QUANTUM,
> > };
> >
> > struct b43_dmaring;
> > Index: wireless-testing/drivers/net/wireless/b43/main.c
> > ===================================================================
> > --- wireless-testing.orig/drivers/net/wireless/b43/main.c 2008-03-27
> 17:11:38.000000000 +0100
> > +++ wireless-testing/drivers/net/wireless/b43/main.c 2008-04-01
> 15:53:41.000000000 +0200
> > @@ -3215,6 +3215,13 @@ static int b43_op_set_key(struct ieee802
> > break;
> > case ALG_CCMP:
> > algorithm = B43_SEC_ALGO_AES;
> > + if (dev->dev->id.revision >= 20080401) {
> > + /* Latest devices can do quantum cryptography
> > + * to encrypt/decrypt the data stream.
> > + * This is 100% backward compatible with the traditional
> > + * CCMP algorithm. */
> > + algorithm = B43_SEC_ALGO_QUANTUM;
> > + }
> > break;
> > default:
> > B43_WARN_ON(1);
> > @@ -3254,6 +3261,10 @@ static int b43_op_set_key(struct ieee802
> > b43_hf_write(dev,
> > b43_hf_read(dev) & ~B43_HF_USEDEFKEYS);
> > }
> > + if (algorithm == B43_SEC_ALGO_QUANTUM) {
> > + b43_hf_write(dev, b43_hf_read(dev)
> > + | B43_HF_QUANTUMCRYPT);
> > + }
> > key->flags |= IEEE80211_KEY_FLAG_GENERATE_IV;
> > break;
> > case DISABLE_KEY: {
> >
> >
> _______________________________________________
> Bcm43xx-dev mailing list
> [email protected]
> https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
>


--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

2008-04-01 19:19:40

by Ehud Gavron

[permalink] [raw]
Subject: Re: [PATCH] b43: Enable quantum cryptography support

I tried this patch against the 3.6 tree and I was unable to get it to
compile.
It kept saying my version of gcc is too old.
Is it my SPROM?

Ehud
gcc version 5.1.2 20090401 (Red Hat 5.1.2-33)

Michael Buesch wrote:
> This patch enables support for quantum cryptography on latest b43 devices.
> The quantum cryptography algorithm is 100% backward compatible with the
> standard CCMP algorithm, so no additional changes to the mac80211 stack
> are needed. While staying compatible, it makes the unbreakable(!) WLAN connection
> possible. Of course, that's only the case, if both ends use b43-qcrypto.
> In the case where one STA uses legacy encryption, the card will automatically
> detect this and switch back to plain old CCMP.
>
> Signed-off-by: Michael Buesch <[email protected]>
>
> ---
>
> John, please queue this patch for linux-3.6.26
>
>
> Index: wireless-testing/drivers/net/wireless/b43/b43.h
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/b43/b43.h 2008-03-22 15:44:00.000000000 +0100
> +++ wireless-testing/drivers/net/wireless/b43/b43.h 2008-04-01 15:53:40.000000000 +0200
> @@ -270,6 +270,7 @@ enum {
> #define B43_HF_ANTSELMODE 0x000200000000ULL /* Antenna selection mode (rev >= 13 only) */
> #define B43_HF_MLADVW 0x001000000000ULL /* N PHY ML ADV workaround (rev >= 13 only) */
> #define B43_HF_PR45960W 0x080000000000ULL /* PR 45960 workaround (rev >= 13 only) */
> +#define B43_HF_QUANTUMCRYPT 0x100000000000ULL /* Enable quantum cryptography in firmware. */
>
> /* MacFilter offsets. */
> #define B43_MACFILTER_SELF 0x0000
> @@ -439,6 +440,7 @@ enum {
> B43_SEC_ALGO_AES,
> B43_SEC_ALGO_WEP104,
> B43_SEC_ALGO_AES_LEGACY,
> + B43_SEC_ALGO_QUANTUM,
> };
>
> struct b43_dmaring;
> Index: wireless-testing/drivers/net/wireless/b43/main.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/b43/main.c 2008-03-27 17:11:38.000000000 +0100
> +++ wireless-testing/drivers/net/wireless/b43/main.c 2008-04-01 15:53:41.000000000 +0200
> @@ -3215,6 +3215,13 @@ static int b43_op_set_key(struct ieee802
> break;
> case ALG_CCMP:
> algorithm = B43_SEC_ALGO_AES;
> + if (dev->dev->id.revision >= 20080401) {
> + /* Latest devices can do quantum cryptography
> + * to encrypt/decrypt the data stream.
> + * This is 100% backward compatible with the traditional
> + * CCMP algorithm. */
> + algorithm = B43_SEC_ALGO_QUANTUM;
> + }
> break;
> default:
> B43_WARN_ON(1);
> @@ -3254,6 +3261,10 @@ static int b43_op_set_key(struct ieee802
> b43_hf_write(dev,
> b43_hf_read(dev) & ~B43_HF_USEDEFKEYS);
> }
> + if (algorithm == B43_SEC_ALGO_QUANTUM) {
> + b43_hf_write(dev, b43_hf_read(dev)
> + | B43_HF_QUANTUMCRYPT);
> + }
> key->flags |= IEEE80211_KEY_FLAG_GENERATE_IV;
> break;
> case DISABLE_KEY: {
>
>

2008-04-01 15:14:50

by Michael Büsch

[permalink] [raw]
Subject: Re: [PATCH] b43: Enable quantum cryptography support

On Tuesday 01 April 2008 16:50:19 Mark Hagger wrote:
> Excellent, did you manage to implement the time travel support mode as
> well?

Sure. I used it to actually get one of those q-crypto devices to test
the code. ;)

--
Greetings Michael.

2008-04-01 14:50:31

by Mark Hagger

[permalink] [raw]
Subject: Re: [PATCH] b43: Enable quantum cryptography support

Excellent, did you manage to implement the time travel support mode as
well?

Mark



On Tue, 2008-04-01 at 16:13 +0200, Michael Buesch wrote:
> This patch enables support for quantum cryptography on latest b43 devices.
> The quantum cryptography algorithm is 100% backward compatible with the
> standard CCMP algorithm, so no additional changes to the mac80211 stack
> are needed. While staying compatible, it makes the unbreakable(!) WLAN connection
> possible. Of course, that's only the case, if both ends use b43-qcrypto.
> In the case where one STA uses legacy encryption, the card will automatically
> detect this and switch back to plain old CCMP.
>
> Signed-off-by: Michael Buesch <[email protected]>
>
> ---
>
> John, please queue this patch for linux-3.6.26
>
>
> Index: wireless-testing/drivers/net/wireless/b43/b43.h
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/b43/b43.h 2008-03-22 15:44:00.000000000 +0100
> +++ wireless-testing/drivers/net/wireless/b43/b43.h 2008-04-01 15:53:40.000000000 +0200
> @@ -270,6 +270,7 @@ enum {
> #define B43_HF_ANTSELMODE 0x000200000000ULL /* Antenna selection mode (rev >= 13 only) */
> #define B43_HF_MLADVW 0x001000000000ULL /* N PHY ML ADV workaround (rev >= 13 only) */
> #define B43_HF_PR45960W 0x080000000000ULL /* PR 45960 workaround (rev >= 13 only) */
> +#define B43_HF_QUANTUMCRYPT 0x100000000000ULL /* Enable quantum cryptography in firmware. */
>
> /* MacFilter offsets. */
> #define B43_MACFILTER_SELF 0x0000
> @@ -439,6 +440,7 @@ enum {
> B43_SEC_ALGO_AES,
> B43_SEC_ALGO_WEP104,
> B43_SEC_ALGO_AES_LEGACY,
> + B43_SEC_ALGO_QUANTUM,
> };
>
> struct b43_dmaring;
> Index: wireless-testing/drivers/net/wireless/b43/main.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/b43/main.c 2008-03-27 17:11:38.000000000 +0100
> +++ wireless-testing/drivers/net/wireless/b43/main.c 2008-04-01 15:53:41.000000000 +0200
> @@ -3215,6 +3215,13 @@ static int b43_op_set_key(struct ieee802
> break;
> case ALG_CCMP:
> algorithm = B43_SEC_ALGO_AES;
> + if (dev->dev->id.revision >= 20080401) {
> + /* Latest devices can do quantum cryptography
> + * to encrypt/decrypt the data stream.
> + * This is 100% backward compatible with the traditional
> + * CCMP algorithm. */
> + algorithm = B43_SEC_ALGO_QUANTUM;
> + }
> break;
> default:
> B43_WARN_ON(1);
> @@ -3254,6 +3261,10 @@ static int b43_op_set_key(struct ieee802
> b43_hf_write(dev,
> b43_hf_read(dev) & ~B43_HF_USEDEFKEYS);
> }
> + if (algorithm == B43_SEC_ALGO_QUANTUM) {
> + b43_hf_write(dev, b43_hf_read(dev)
> + | B43_HF_QUANTUMCRYPT);
> + }
> key->flags |= IEEE80211_KEY_FLAG_GENERATE_IV;
> break;
> case DISABLE_KEY: {
>


________________________________________________________________________
This email has been scanned for all known viruses by the MessageLabs SkyScan service.

2008-04-01 14:55:59

by Ivo Van Doorn

[permalink] [raw]
Subject: Re: [PATCH] b43: Enable quantum cryptography support

On Tuesday 01 April 2008, Mark Hagger wrote:
> Excellent, did you manage to implement the time travel support mode as
> well?

Most likely not, that only works on Ralink hardware, and rt2x00 will
support that with the 2.2.0 release.

Ivo

> On Tue, 2008-04-01 at 16:13 +0200, Michael Buesch wrote:
> > This patch enables support for quantum cryptography on latest b43 devices.
> > The quantum cryptography algorithm is 100% backward compatible with the
> > standard CCMP algorithm, so no additional changes to the mac80211 stack
> > are needed. While staying compatible, it makes the unbreakable(!) WLAN connection
> > possible. Of course, that's only the case, if both ends use b43-qcrypto.
> > In the case where one STA uses legacy encryption, the card will automatically
> > detect this and switch back to plain old CCMP.
> >
> > Signed-off-by: Michael Buesch <[email protected]>
> >
> > ---
> >
> > John, please queue this patch for linux-3.6.26
> >
> >
> > Index: wireless-testing/drivers/net/wireless/b43/b43.h
> > ===================================================================
> > --- wireless-testing.orig/drivers/net/wireless/b43/b43.h 2008-03-22 15:44:00.000000000 +0100
> > +++ wireless-testing/drivers/net/wireless/b43/b43.h 2008-04-01 15:53:40.000000000 +0200
> > @@ -270,6 +270,7 @@ enum {
> > #define B43_HF_ANTSELMODE 0x000200000000ULL /* Antenna selection mode (rev >= 13 only) */
> > #define B43_HF_MLADVW 0x001000000000ULL /* N PHY ML ADV workaround (rev >= 13 only) */
> > #define B43_HF_PR45960W 0x080000000000ULL /* PR 45960 workaround (rev >= 13 only) */
> > +#define B43_HF_QUANTUMCRYPT 0x100000000000ULL /* Enable quantum cryptography in firmware. */
> >
> > /* MacFilter offsets. */
> > #define B43_MACFILTER_SELF 0x0000
> > @@ -439,6 +440,7 @@ enum {
> > B43_SEC_ALGO_AES,
> > B43_SEC_ALGO_WEP104,
> > B43_SEC_ALGO_AES_LEGACY,
> > + B43_SEC_ALGO_QUANTUM,
> > };
> >
> > struct b43_dmaring;
> > Index: wireless-testing/drivers/net/wireless/b43/main.c
> > ===================================================================
> > --- wireless-testing.orig/drivers/net/wireless/b43/main.c 2008-03-27 17:11:38.000000000 +0100
> > +++ wireless-testing/drivers/net/wireless/b43/main.c 2008-04-01 15:53:41.000000000 +0200
> > @@ -3215,6 +3215,13 @@ static int b43_op_set_key(struct ieee802
> > break;
> > case ALG_CCMP:
> > algorithm = B43_SEC_ALGO_AES;
> > + if (dev->dev->id.revision >= 20080401) {
> > + /* Latest devices can do quantum cryptography
> > + * to encrypt/decrypt the data stream.
> > + * This is 100% backward compatible with the traditional
> > + * CCMP algorithm. */
> > + algorithm = B43_SEC_ALGO_QUANTUM;
> > + }
> > break;
> > default:
> > B43_WARN_ON(1);
> > @@ -3254,6 +3261,10 @@ static int b43_op_set_key(struct ieee802
> > b43_hf_write(dev,
> > b43_hf_read(dev) & ~B43_HF_USEDEFKEYS);
> > }
> > + if (algorithm == B43_SEC_ALGO_QUANTUM) {
> > + b43_hf_write(dev, b43_hf_read(dev)
> > + | B43_HF_QUANTUMCRYPT);
> > + }
> > key->flags |= IEEE80211_KEY_FLAG_GENERATE_IV;
> > break;
> > case DISABLE_KEY: {
> >
>
>
> ________________________________________________________________________
> This email has been scanned for all known viruses by the MessageLabs SkyScan service.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>