2008-04-24 10:50:46

by Priit Laes

[permalink] [raw]
Subject: [PATCH] iwlwifi: Select also LEDS_TRIGGERS.

Following patch fixes build for me..

Attachments:
iwlwifi-fix-leds-build.patch (971.00 B)

2008-04-26 16:16:17

by Johannes Berg

[permalink] [raw]
Subject: Re: [PATCH] iwlwifi: Select also LEDS_TRIGGERS.

On Thu, 2008-04-24 at 14:24 +0300, Tomas Winkler wrote:
> Shouldn't be this already covered by MAC80211_LEDS

No, select isn't transitive.

johannes

Attachments:
signature.asc (828.00 B)
This is a digitally signed message part

2008-04-24 11:24:54

by Tomas Winkler

[permalink] [raw]
Subject: Re: [PATCH] iwlwifi: Select also LEDS_TRIGGERS.

Shouldn't be this already covered by MAC80211_LEDS

depends on IWL4965
select MAC80211_LEDS
select LEDS_CLASS
+ select LEDS_TRIGGERS
select IWLWIFI_LEDS

On Thu, Apr 24, 2008 at 1:42 PM, Priit Laes <[email protected]> wrote:
> Following patch fixes build for me..
>

2008-04-26 17:08:17

by Tomas Winkler

[permalink] [raw]
Subject: Re: [PATCH] iwlwifi: Select also LEDS_TRIGGERS.

On Sat, Apr 26, 2008 at 7:16 PM, Johannes Berg
<[email protected]> wrote:
> On Thu, 2008-04-24 at 14:24 +0300, Tomas Winkler wrote:
> > Shouldn't be this already covered by MAC80211_LEDS
>
> No, select isn't transitive.

Oh boy I hate when things are not intuitive... force me to read manuals ;)
Thanks
Tomas

> johannes
>

2008-04-24 12:13:05

by Priit Laes

[permalink] [raw]
Subject: Re: [PATCH] iwlwifi: Select also LEDS_TRIGGERS.

=C3=9Chel kenal p=C3=A4eval, N, 2008-04-24 kell 14:24, kirjutas Tomas W=
inkler:
> Shouldn't be this already covered by MAC80211_LEDS
>=20
> depends on IWL4965
> select MAC80211_LEDS
> select LEDS_CLASS
> + select LEDS_TRIGGERS
> select IWLWIFI_LEDS

Compile failed for me until I selected LEDS_TRIGGERS myself.