2008-10-28 18:36:12

by Johannes Berg

[permalink] [raw]
Subject: [PATCH] wireless: fix a few sparse warnings

Signed-off-by: Johannes Berg <[email protected]>
---
net/mac80211/rc80211_minstrel.c | 2 +-
net/mac80211/tx.c | 1 -
net/wireless/reg.c | 2 +-
3 files changed, 2 insertions(+), 3 deletions(-)

--- everything.orig/net/mac80211/rc80211_minstrel.c 2008-10-28 16:42:59.000000000 +0100
+++ everything/net/mac80211/rc80211_minstrel.c 2008-10-28 16:43:08.000000000 +0100
@@ -225,7 +225,7 @@ minstrel_get_next_sample(struct minstrel
return sample_ndx;
}

-void
+static void
minstrel_get_rate(void *priv, struct ieee80211_sta *sta,
void *priv_sta, struct ieee80211_tx_rate_control *txrc)
{
--- everything.orig/net/mac80211/tx.c 2008-10-28 16:43:18.000000000 +0100
+++ everything/net/mac80211/tx.c 2008-10-28 16:43:44.000000000 +0100
@@ -700,7 +700,6 @@ ieee80211_tx_h_fragment(struct ieee80211
left = payload_len - per_fragm;
for (i = 0; i < num_fragm - 1; i++) {
struct ieee80211_hdr *fhdr;
- struct ieee80211_tx_info *info;
size_t copylen;

if (left <= 0)
--- everything.orig/net/wireless/reg.c 2008-10-28 16:45:29.000000000 +0100
+++ everything/net/wireless/reg.c 2008-10-28 16:45:33.000000000 +0100
@@ -638,7 +638,7 @@ static void print_regdomain(const struct
print_rd_rules(rd);
}

-void print_regdomain_info(const struct ieee80211_regdomain *rd)
+static void print_regdomain_info(const struct ieee80211_regdomain *rd)
{
printk(KERN_INFO "cfg80211: Regulatory domain: %c%c\n",
rd->alpha2[0], rd->alpha2[1]);




2008-10-28 18:50:31

by Johannes Berg

[permalink] [raw]
Subject: Re: [PATCH] wireless: fix a few sparse warnings

On Tue, 2008-10-28 at 11:48 -0700, Harvey Harrison wrote:
> On Tue, 2008-10-28 at 16:49 +0100, Johannes Berg wrote:
> > Signed-off-by: Johannes Berg <[email protected]>
> > ---
>
> It's helpful to put the warnings that are being fixed in the commit
> message.

Indeed, but I fixed them over time so I was too lazy to reproduce
them :) In any case, it should be easy to deduce them by looking at the
patch.

johannes


Attachments:
signature.asc (836.00 B)
This is a digitally signed message part

2008-10-28 18:48:27

by Harvey Harrison

[permalink] [raw]
Subject: Re: [PATCH] wireless: fix a few sparse warnings

On Tue, 2008-10-28 at 16:49 +0100, Johannes Berg wrote:
> Signed-off-by: Johannes Berg <[email protected]>
> ---

It's helpful to put the warnings that are being fixed in the commit
message.

Cheers,

Harvey