2008-10-29 11:49:15

by Johannes Berg

Subject: [PATCH] iwl3945: remove bogus comment

I added this comment myself, but it's clearly wrong. I had meant
to place it in iwl_mac_add_interface, which at the time didn't
honour the MAC address setting, but it does now.

Signed-off-by: Johannes Berg <[email protected]>
---
drivers/net/wireless/iwlwifi/iwl3945-base.c | 2 --
1 file changed, 2 deletions(-)

--- everything.orig/drivers/net/wireless/iwlwifi/iwl3945-base.c 2008-10-29 00:58:17.000000000 +0100
+++ everything/drivers/net/wireless/iwlwifi/iwl3945-base.c 2008-10-29 00:58:26.000000000 +0100
@@ -6742,8 +6742,6 @@ static int iwl3945_mac_config_interface(
return rc;
}

- /* XXX: this MUST use conf->mac_addr */
-
if (!iwl3945_is_alive(priv))
return -EAGAIN;

2008-10-29 17:29:29

by Reinette Chatre

Subject: Re: [PATCH] iwl3945: remove bogus comment

On Tue, 2008-10-28 at 17:02 -0700, Johannes Berg wrote:
> I added this comment myself, but it's clearly wrong. I had meant
> to place it in iwl_mac_add_interface, which at the time didn't
> honour the MAC address setting, but it does now.
>
> Signed-off-by: Johannes Berg <[email protected]>

Thanks Johannes

ack

Reinette