2008-10-29 17:53:27

by Jouni Malinen

[permalink] [raw]
Subject: [PATCH 1/4] mac80211_hwsim: Debug info for BSS config changes

Provide detailed information on BSS configuration changes to make it
easier to debug mac80211 functionality.

Signed-off-by: Jouni Malinen <[email protected]>

Index: wireless-testing/drivers/net/wireless/mac80211_hwsim.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/mac80211_hwsim.c
+++ wireless-testing/drivers/net/wireless/mac80211_hwsim.c
@@ -415,6 +415,37 @@ static void mac80211_hwsim_bss_info_chan
u32 changed)
{
hwsim_check_magic(vif);
+ printk(KERN_DEBUG "%s:%s(changed=0x%x)\n",
+ wiphy_name(hw->wiphy), __func__, changed);
+
+ if (changed & BSS_CHANGED_ASSOC) {
+ printk(KERN_DEBUG " ASSOC: assoc=%d aid=%d\n",
+ info->assoc, info->aid);
+ }
+
+ if (changed & BSS_CHANGED_ERP_CTS_PROT) {
+ printk(KERN_DEBUG " ERP_CTS_PROT: %d\n", info->use_cts_prot);
+ }
+
+ if (changed & BSS_CHANGED_ERP_PREAMBLE) {
+ printk(KERN_DEBUG " ERP_PREAMBLE: %d\n",
+ info->use_short_preamble);
+ }
+
+ if (changed & BSS_CHANGED_ERP_SLOT) {
+ printk(KERN_DEBUG " ERP_SLOT: %d\n", info->use_short_slot);
+ }
+
+ if (changed & BSS_CHANGED_HT) {
+ printk(KERN_DEBUG " HT: sec_ch_offs=%d width_40_ok=%d "
+ "op_mode=%d\n", info->ht.secondary_channel_offset,
+ info->ht.width_40_ok, info->ht.operation_mode);
+ }
+
+ if (changed & BSS_CHANGED_BASIC_RATES) {
+ printk(KERN_DEBUG " BASIC_RATES: 0x%llx\n",
+ info->basic_rates);
+ }
}

static void mac80211_hwsim_sta_notify(struct ieee80211_hw *hw,

--

--
Jouni Malinen PGP id EFC895FA


2008-10-30 10:42:53

by Johannes Berg

[permalink] [raw]
Subject: Re: [PATCH 1/4] mac80211_hwsim: Debug info for BSS config changes


> + printk(KERN_DEBUG "%s:%s(changed=0x%x)\n",
> + wiphy_name(hw->wiphy), __func__, changed);

Should we print the wiphy name for each line below too so we can parse
this more easily with some validation tools?


> + if (changed & BSS_CHANGED_BASIC_RATES) {
> + printk(KERN_DEBUG " BASIC_RATES: 0x%llx\n",
> + info->basic_rates);

That'll need an (unsigned long long) cast.

johannes


Attachments:
signature.asc (836.00 B)
This is a digitally signed message part