'iwconfig eth1 channel 6' would trigger association to _something_, which is wrong. Changing the channel should (and does) trigger reassociation, but only if there is an SSID to associate with!
---
drivers/net/wireless/ipw2200.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ipw2200.c b/drivers/net/wireless/ipw2200.c
index dcce354..d26beed 100644
--- a/drivers/net/wireless/ipw2200.c
+++ b/drivers/net/wireless/ipw2200.c
@@ -7581,8 +7581,7 @@ static int ipw_associate(void *data)
}
if (!(priv->config & CFG_ASSOCIATE) &&
- !(priv->config & (CFG_STATIC_ESSID |
- CFG_STATIC_CHANNEL | CFG_STATIC_BSSID))) {
+ !(priv->config & (CFG_STATIC_ESSID | CFG_STATIC_BSSID))) {
IPW_DEBUG_ASSOC("Not attempting association (associate=0)\n");
return 0;
}
--
1.5.6.3
Alexey Fisher <[email protected]> writes:
> Am Mittwoch, den 05.11.2008, 07:25 +0200 schrieb Kalle Valo:
>> Dan Williams <[email protected]> writes:
>>
>> > On Tue, 2008-11-04 at 23:01 +0100, Alexey Fisher wrote:
>> >> 'iwconfig eth1 channel 6' would trigger association to _something_,
>> >> which is wrong. Changing the channel should (and does) trigger
>> >> reassociation, but only if there is an SSID to associate with!
>> >
>> > Heh :) Need the Signed-off-by: here too though.
>>
>> And the subject should contain the driver name, for example like this:
>
> I found some time to _read_ linux-2.6/Documentation/Submit* ! ;)
> but i think it need some "howto submit the patch with git". My englisch
> is to bad to make documentation. Here was my steps:
>
> $git clone
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
> $git pull
> $vi make/changes
> $git-commit -a
In this phase just write the commit log in this style:
----------------------------------------------------------------------
stlc45xx: fix bug in blah blah
stlc45xx was really broken in blah blah blah, I had
to blah blah blah.
Signed-off-by: Kalle Valo <[email protected]>
----------------------------------------------------------------------
git will take care of the rest.
--
Kalle Valo
On Tue, 2008-11-04 at 23:01 +0100, Alexey Fisher wrote:
> 'iwconfig eth1 channel 6' would trigger association to _something_, which is wrong. Changing the channel should (and does) trigger reassociation, but only if there is an SSID to associate with!
Heh :) Need the Signed-off-by: here too though.
Dan
> drivers/net/wireless/ipw2200.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ipw2200.c b/drivers/net/wireless/ipw2200.c
> index dcce354..d26beed 100644
> --- a/drivers/net/wireless/ipw2200.c
> +++ b/drivers/net/wireless/ipw2200.c
> @@ -7581,8 +7581,7 @@ static int ipw_associate(void *data)
> }
>
> if (!(priv->config & CFG_ASSOCIATE) &&
> - !(priv->config & (CFG_STATIC_ESSID |
> - CFG_STATIC_CHANNEL | CFG_STATIC_BSSID))) {
> + !(priv->config & (CFG_STATIC_ESSID | CFG_STATIC_BSSID))) {
> IPW_DEBUG_ASSOC("Not attempting association (associate=0)\n");
> return 0;
> }
Dan Williams <[email protected]> writes:
> On Tue, 2008-11-04 at 23:01 +0100, Alexey Fisher wrote:
>> 'iwconfig eth1 channel 6' would trigger association to _something_,
>> which is wrong. Changing the channel should (and does) trigger
>> reassociation, but only if there is an SSID to associate with!
>
> Heh :) Need the Signed-off-by: here too though.
And the subject should contain the driver name, for example like this:
[PATCH] ipw2200: associate only when SSID is known
--
Kalle Valo
Am Mittwoch, den 05.11.2008, 07:25 +0200 schrieb Kalle Valo:
> Dan Williams <[email protected]> writes:
>
> > On Tue, 2008-11-04 at 23:01 +0100, Alexey Fisher wrote:
> >> 'iwconfig eth1 channel 6' would trigger association to _something_,
> >> which is wrong. Changing the channel should (and does) trigger
> >> reassociation, but only if there is an SSID to associate with!
> >
> > Heh :) Need the Signed-off-by: here too though.
>
> And the subject should contain the driver name, for example like this:
I found some time to _read_ linux-2.6/Documentation/Submit* ! ;)
but i think it need some "howto submit the patch with git". My englisch
is to bad to make documentation. Here was my steps:
$git clone
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
$git pull
$vi make/changes
$git-commit -a
$git-log -p ORIG_HEAD..
$mkdir ../pending
$git-format-patch ORIG_HEAD.. -o ../pending/
$vi ../pending/0001-ipw2200.patch
$git-send-email --cc [email protected] --to
[email protected] --from "Alexey Fisher
<[email protected]>" --smtp-server mail.gmx.net --smtp-user
[email protected] --smtp-ssl ../pending/0001-ipw2200.patch