2008-11-22 03:22:57

by cheng renquan

[permalink] [raw]
Subject: [PATCH] ath5k: fix Security issue in DebugFS part of ath5k

=46rom: Cheng Renquan <[email protected]>

http://bugzilla.kernel.org/show_bug.cgi?id=3D12076

Remove any write access to groups and others, only keep write permissio=
n
to its owner, usually only root user.

Reported-by: J=C3=A9r=C3=B4me Poulin <[email protected]>
Signed-off-by: Cheng Renquan <[email protected]>
---
drivers/net/wireless/ath5k/debug.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/wireless/ath5k/debug.c b/drivers/net/wireless/=
ath5k/debug.c
index 19980cb..ccaeb5c 100644
--- a/drivers/net/wireless/ath5k/debug.c
+++ b/drivers/net/wireless/ath5k/debug.c
@@ -417,19 +417,19 @@ ath5k_debug_init_device(struct ath5k_softc *sc)
sc->debug.debugfs_phydir =3D debugfs_create_dir(wiphy_name(sc->hw->wi=
phy),
ath5k_global_debugfs);
=20
- sc->debug.debugfs_debug =3D debugfs_create_file("debug", 0666,
+ sc->debug.debugfs_debug =3D debugfs_create_file("debug", S_IWUSR | S_=
IRUGO,
sc->debug.debugfs_phydir, sc, &fops_debug);
=20
- sc->debug.debugfs_registers =3D debugfs_create_file("registers", 0444=
,
+ sc->debug.debugfs_registers =3D debugfs_create_file("registers", S_IR=
UGO,
sc->debug.debugfs_phydir, sc, &fops_registers);
=20
- sc->debug.debugfs_tsf =3D debugfs_create_file("tsf", 0666,
+ sc->debug.debugfs_tsf =3D debugfs_create_file("tsf", S_IWUSR | S_IRUG=
O,
sc->debug.debugfs_phydir, sc, &fops_tsf);
=20
- sc->debug.debugfs_beacon =3D debugfs_create_file("beacon", 0666,
+ sc->debug.debugfs_beacon =3D debugfs_create_file("beacon", S_IWUSR | =
S_IRUGO,
sc->debug.debugfs_phydir, sc, &fops_beacon);
=20
- sc->debug.debugfs_reset =3D debugfs_create_file("reset", 0222,
+ sc->debug.debugfs_reset =3D debugfs_create_file("reset", S_IWUSR,
sc->debug.debugfs_phydir, sc, &fops_reset);
}
=20
--=20
1.6.0.4.758.g36c05