2009-01-12 20:00:43

by John W. Linville

Subject: [PATCH] mac80211: fix "‘ret’ may be used uninitialized" warning

net/mac80211/ht.c: In function =E2=80=98ieee80211_start_tx_ba_session=E2=
=80=99:
net/mac80211/ht.c:472: warning: =E2=80=98ret=E2=80=99 may be used unini=
tialized in this function

Signed-off-by: John W. Linville <[email protected]>
---
net/mac80211/ht.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
delete mode 100644 arch/arm/mach-integrator/clock.h

diff --git a/arch/arm/mach-integrator/clock.h b/arch/arm/mach-integrato=
r/clock.h
deleted file mode 100644
index e69de29..0000000
diff --git a/net/mac80211/ht.c b/net/mac80211/ht.c
index 5f510a1..c5c0c52 100644
--- a/net/mac80211/ht.c
+++ b/net/mac80211/ht.c
@@ -469,7 +469,7 @@ int ieee80211_start_tx_ba_session(struct ieee80211_=
hw *hw, u8 *ra, u16 tid)
struct ieee80211_sub_if_data *sdata;
u16 start_seq_num;
u8 *state;
- int ret;
+ int ret =3D 0;
=20
if ((tid >=3D STA_TID_NUM) || !(hw->flags & IEEE80211_HW_AMPDU_AGGREG=
ATION))
return -EINVAL;
--=20
1.5.4.3

2009-01-12 21:33:44

by Reinette Chatre

Subject: Re: [PATCH] iwl3945: fix "‘power_idx’ may be used uninitialized" warning

On Mon, 2009-01-12 at 11:49 -0800, John W. Linville wrote:
> drivers/net/wireless/iwlwifi/iwl-3945.c: In function =E2=80=98iwl3945=
_txpower_set_from_eeprom=E2=80=99:
> drivers/net/wireless/iwlwifi/iwl-3945.c:2222: warning: =E2=80=98power=
_idx=E2=80=99 may be used uninitialized in this function
>=20
> Signed-off-by: John W. Linville <[email protected]>
> ---
> drivers/net/wireless/iwlwifi/iwl-3945.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>=20
> diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wi=
reless/iwlwifi/iwl-3945.c
> index 8fdb342..45cfa1c 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-3945.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
> @@ -2219,7 +2219,7 @@ int iwl3945_txpower_set_from_eeprom(struct iwl3=
945_priv *priv)
> /* set tx power value for all OFDM rates */
> for (rate_index =3D 0; rate_index < IWL_OFDM_RATES;
> rate_index++) {
> - s32 power_idx;
> + s32 uninitialized_var(power_idx);
> int rc;
> =20
> /* use channel group's clip-power table,

Thank you very much

Acked-by: Reinette Chatre <[email protected]>

Reinette

2009-01-12 20:12:05

by Larry Finger

Subject: Re: [PATCH] b43legacy: fix "‘up_dev’ may be used uninitialized" warning

John W. Linville wrote:
> drivers/net/wireless/b43legacy/main.c: In function =E2=80=98b43legacy=
_op_dev_config=E2=80=99:
> drivers/net/wireless/b43legacy/main.c:2468: warning: =E2=80=98up_dev=E2=
=80=99 may be used uninitialized in this function
>=20
> Signed-off-by: John W. Linville <[email protected]>
> ---
> drivers/net/wireless/b43legacy/main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>=20
> diff --git a/drivers/net/wireless/b43legacy/main.c b/drivers/net/wire=
less/b43legacy/main.c
> index c1324e3..fb996c2 100644
> --- a/drivers/net/wireless/b43legacy/main.c
> +++ b/drivers/net/wireless/b43legacy/main.c
> @@ -2465,7 +2465,7 @@ static void b43legacy_put_phy_into_reset(struct=
b43legacy_wldev *dev)
> static int b43legacy_switch_phymode(struct b43legacy_wl *wl,
> unsigned int new_mode)
> {
> - struct b43legacy_wldev *up_dev;
> + struct b43legacy_wldev *uninitialized_var(up_dev);
> struct b43legacy_wldev *down_dev;
> int err;
> bool gmode =3D 0;

It seems that some versions of gcc don't do the flow analysis
correctly, so

ACK

Larry

2009-01-12 20:00:43

by John W. Linville

Subject: [PATCH] iwl3945: fix "‘power_idx’ may be used uninitialized" warning

drivers/net/wireless/iwlwifi/iwl-3945.c: In function =E2=80=98iwl3945_t=
xpower_set_from_eeprom=E2=80=99:
drivers/net/wireless/iwlwifi/iwl-3945.c:2222: warning: =E2=80=98power_i=
dx=E2=80=99 may be used uninitialized in this function

Signed-off-by: John W. Linville <[email protected]>
---
drivers/net/wireless/iwlwifi/iwl-3945.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wire=
less/iwlwifi/iwl-3945.c
index 8fdb342..45cfa1c 100644
--- a/drivers/net/wireless/iwlwifi/iwl-3945.c
+++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
@@ -2219,7 +2219,7 @@ int iwl3945_txpower_set_from_eeprom(struct iwl394=
5_priv *priv)
/* set tx power value for all OFDM rates */
for (rate_index =3D 0; rate_index < IWL_OFDM_RATES;
rate_index++) {
- s32 power_idx;
+ s32 uninitialized_var(power_idx);
int rc;
=20
/* use channel group's clip-power table,
--=20
1.5.4.3

2009-01-12 20:30:42

by John W. Linville

Subject: Re: [PATCH] b43: fix "‘gmode’ may be used uninitialized" warning

On Mon, Jan 12, 2009 at 02:10:07PM -0600, Larry Finger wrote:
> John W. Linville wrote:
> > drivers/net/wireless/b43/main.c: In function =E2=80=98b43_op_config=
=E2=80=99:
> > drivers/net/wireless/b43/main.c:3264: warning: =E2=80=98gmode=E2=80=
=99 may be used uninitialized
>=20
> What version of gcc generates this warning? Mine (gcc (SUSE Linux)
> 4.3.2) does not.

gcc -v gives "gcc version 4.1.2 20070925 (Red Hat 4.1.2-33)"

--=20
John W. Linville Linux should be at the core
[email protected] of your literate lifestyle.

2009-01-12 20:00:43

by John W. Linville

Subject: [PATCH] b43legacy: fix "‘up_dev’ may be used uninitialized" warning

drivers/net/wireless/b43legacy/main.c: In function =E2=80=98b43legacy_o=
p_dev_config=E2=80=99:
drivers/net/wireless/b43legacy/main.c:2468: warning: =E2=80=98up_dev=E2=
=80=99 may be used uninitialized in this function

Signed-off-by: John W. Linville <[email protected]>
---
drivers/net/wireless/b43legacy/main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/b43legacy/main.c b/drivers/net/wirele=
ss/b43legacy/main.c
index c1324e3..fb996c2 100644
--- a/drivers/net/wireless/b43legacy/main.c
+++ b/drivers/net/wireless/b43legacy/main.c
@@ -2465,7 +2465,7 @@ static void b43legacy_put_phy_into_reset(struct b=
43legacy_wldev *dev)
static int b43legacy_switch_phymode(struct b43legacy_wl *wl,
unsigned int new_mode)
{
- struct b43legacy_wldev *up_dev;
+ struct b43legacy_wldev *uninitialized_var(up_dev);
struct b43legacy_wldev *down_dev;
int err;
bool gmode =3D 0;
--=20
1.5.4.3

2009-01-12 20:10:14

by Larry Finger

Subject: Re: [PATCH] b43: fix "‘gmode’ may be used uninitialized" warning

John W. Linville wrote:
> drivers/net/wireless/b43/main.c: In function =E2=80=98b43_op_config=E2=
=80=99:
> drivers/net/wireless/b43/main.c:3264: warning: =E2=80=98gmode=E2=80=99=
may be used uninitialized

What version of gcc generates this warning? Mine (gcc (SUSE Linux)
4.3.2) does not.

Larry

2009-01-12 20:47:34

by Christian Lamparter

Subject: Re: [PATCH] p54: fix " ‘ret’ may be used uninitialized" warning

On Monday 12 January 2009 20:49:01 John W. Linville wrote:
> drivers/net/wireless/p54/p54common.c: In function =E2=80=98p54_config=
=E2=80=99:
> drivers/net/wireless/p54/p54common.c:1853: warning: =E2=80=98ret=E2=80=
=99 may be used uninitialized in this function
>=20
> Signed-off-by: John W. Linville <[email protected]>
ACK

> ---
> drivers/net/wireless/p54/p54common.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>=20
> diff --git a/drivers/net/wireless/p54/p54common.c b/drivers/net/wirel=
ess/p54/p54common.c
> index cba89ed..c6a370f 100644
> --- a/drivers/net/wireless/p54/p54common.c
> +++ b/drivers/net/wireless/p54/p54common.c
> @@ -1850,7 +1850,7 @@ static void p54_remove_interface(struct ieee802=
11_hw *dev,
> =20
> static int p54_config(struct ieee80211_hw *dev, u32 changed)
> {
> - int ret;
> + int ret =3D 0;
> struct p54_common *priv =3D dev->priv;
> struct ieee80211_conf *conf =3D &dev->conf;
> =20

2009-01-12 20:00:43

by John W. Linville

Subject: [PATCH] b43: fix "‘gmode’ may be used uninitialized" warning

drivers/net/wireless/b43/main.c: In function =E2=80=98b43_op_config=E2=80=
=99:
drivers/net/wireless/b43/main.c:3264: warning: =E2=80=98gmode=E2=80=99 =
may be used uninitialized

Signed-off-by: John W. Linville <[email protected]>
---
drivers/net/wireless/b43/main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43=
/main.c
index 7b31a32..c788bad 100644
--- a/drivers/net/wireless/b43/main.c
+++ b/drivers/net/wireless/b43/main.c
@@ -3261,7 +3261,7 @@ static int b43_switch_band(struct b43_wl *wl, str=
uct ieee80211_channel *chan)
struct b43_wldev *down_dev;
struct b43_wldev *d;
int err;
- bool gmode;
+ bool uninitialized_var(gmode);
int prev_status;
=20
/* Find a device and PHY which supports the band. */
--=20
1.5.4.3

2009-01-12 20:00:43

by John W. Linville

Subject: [PATCH] p54: fix "‘ret’ may be used uninitialized" warning

drivers/net/wireless/p54/p54common.c: In function =E2=80=98p54_config=E2=
=80=99:
drivers/net/wireless/p54/p54common.c:1853: warning: =E2=80=98ret=E2=80=99=
may be used uninitialized in this function

Signed-off-by: John W. Linville <[email protected]>
---
drivers/net/wireless/p54/p54common.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/p54/p54common.c b/drivers/net/wireles=
s/p54/p54common.c
index cba89ed..c6a370f 100644
--- a/drivers/net/wireless/p54/p54common.c
+++ b/drivers/net/wireless/p54/p54common.c
@@ -1850,7 +1850,7 @@ static void p54_remove_interface(struct ieee80211=
_hw *dev,
=20
static int p54_config(struct ieee80211_hw *dev, u32 changed)
{
- int ret;
+ int ret =3D 0;
struct p54_common *priv =3D dev->priv;
struct ieee80211_conf *conf =3D &dev->conf;
=20
--=20
1.5.4.3

2009-01-12 20:09:39

by Michael Büsch

Subject: Re: [PATCH] b43: fix " ‘gmode’ may be used uninitialized" warning

On Monday 12 January 2009 20:48:58 John W. Linville wrote:
> drivers/net/wireless/b43/main.c: In function =E2=80=98b43_op_config=E2=
=80=99:
> drivers/net/wireless/b43/main.c:3264: warning: =E2=80=98gmode=E2=80=99=
may be used uninitialized

Stupid gcc :P

> Signed-off-by: John W. Linville <[email protected]>

ACK

> ---
> drivers/net/wireless/b43/main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>=20
> diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b=
43/main.c
> index 7b31a32..c788bad 100644
> --- a/drivers/net/wireless/b43/main.c
> +++ b/drivers/net/wireless/b43/main.c
> @@ -3261,7 +3261,7 @@ static int b43_switch_band(struct b43_wl *wl, s=
truct ieee80211_channel *chan)
> struct b43_wldev *down_dev;
> struct b43_wldev *d;
> int err;
> - bool gmode;
> + bool uninitialized_var(gmode);
> int prev_status;
> =20
> /* Find a device and PHY which supports the band. */



--=20
Greetings, Michael.

2009-01-12 20:11:34

by Michael Büsch

Subject: Re: [PATCH] b43legacy: fix " ‘up_dev’ may be used uninitialized" warning

On Monday 12 January 2009 20:48:59 John W. Linville wrote:
> drivers/net/wireless/b43legacy/main.c: In function =E2=80=98b43legacy=
_op_dev_config=E2=80=99:
> drivers/net/wireless/b43legacy/main.c:2468: warning: =E2=80=98up_dev=E2=
=80=99 may be used uninitialized in this function
>=20
> Signed-off-by: John W. Linville <[email protected]>

ACK

> ---
> drivers/net/wireless/b43legacy/main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>=20
> diff --git a/drivers/net/wireless/b43legacy/main.c b/drivers/net/wire=
less/b43legacy/main.c
> index c1324e3..fb996c2 100644
> --- a/drivers/net/wireless/b43legacy/main.c
> +++ b/drivers/net/wireless/b43legacy/main.c
> @@ -2465,7 +2465,7 @@ static void b43legacy_put_phy_into_reset(struct=
b43legacy_wldev *dev)
> static int b43legacy_switch_phymode(struct b43legacy_wl *wl,
> unsigned int new_mode)
> {
> - struct b43legacy_wldev *up_dev;
> + struct b43legacy_wldev *uninitialized_var(up_dev);
> struct b43legacy_wldev *down_dev;
> int err;
> bool gmode =3D 0;



--=20
Greetings, Michael.