2009-02-24 02:43:40

by Jason Andryuk

Subject: [PATCH] iwl3945: initialize is_valid_rtc_data_addr function pointer

Initialize is_valid_rtc_data_addr function pointer for iwl3945 to
prevent a NULL pointer dereference in iwl_dump_nic_error_log.

Signed-off-by: Jason Andryuk <[email protected]>
--

diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wireless/iwlwifi/iwl-3945.c
index d49e48b..6ae0df5 100644
--- a/drivers/net/wireless/iwlwifi/iwl-3945.c
+++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
@@ -2747,6 +2747,7 @@ static struct iwl_lib_ops iwl3945_lib = {
.query_addr = iwlcore_eeprom_query_addr,
},
.send_tx_power = iwl3945_send_tx_power,
+ .is_valid_rtc_data_addr = iwl3945_hw_valid_rtc_data_addr,
};

static struct iwl_hcmd_utils_ops iwl3945_hcmd_utils = {

2009-02-24 05:02:54

by Reinette Chatre

Subject: Re: [PATCH] iwl3945: initialize is_valid_rtc_data_addr function pointer

On Mon, 2009-02-23 at 18:43 -0800, Jason Andryuk wrote:
> Initialize is_valid_rtc_data_addr function pointer for iwl3945 to
> prevent a NULL pointer dereference in iwl_dump_nic_error_log.
>
> Signed-off-by: Jason Andryuk <[email protected]>
> --
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wireless/iwlwifi/iwl-3945.c
> index d49e48b..6ae0df5 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-3945.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
> @@ -2747,6 +2747,7 @@ static struct iwl_lib_ops iwl3945_lib = {
> .query_addr = iwlcore_eeprom_query_addr,
> },
> .send_tx_power = iwl3945_send_tx_power,
> + .is_valid_rtc_data_addr = iwl3945_hw_valid_rtc_data_addr,
> };
>
> static struct iwl_hcmd_utils_ops iwl3945_hcmd_utils = {
>

Thank you very much

Acked-by: Reinette Chatre <[email protected]>


Reinette