2009-04-22 15:34:20

by Johannes Berg

Subject: [PATCH] iwl3945: fix section type conflict on powerpc

For some reason on powerpc I get:

drivers/net/wireless/iwlwifi/iwl3945-base.c:1416: error:
__ksymtab_iwl3945_rx_queue_reset causes a section type conflict
drivers/net/wireless/iwlwifi/iwl3945-base.c:1416: error:
__ksymtab_iwl3945_rx_queue_reset causes a section type conflict

The function doesn't need to be exported, and unexporting fixes it,
so I'm not thinking about what is causing it.

Signed-off-by: Johannes Berg <[email protected]>
---
drivers/net/wireless/iwlwifi/iwl3945-base.c | 1 -
1 file changed, 1 deletion(-)

--- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl3945-base.c 2009-04-22 17:16:53.614082341 +0200
+++ wireless-testing/drivers/net/wireless/iwlwifi/iwl3945-base.c 2009-04-22 17:16:55.382327490 +0200
@@ -1413,7 +1413,6 @@ void iwl3945_rx_queue_reset(struct iwl_p
rxq->free_count = 0;
spin_unlock_irqrestore(&rxq->lock, flags);
}
-EXPORT_SYMBOL(iwl3945_rx_queue_reset);

/*
* this should be called while priv->lock is locked

2009-04-22 17:57:28

by Reinette Chatre

Subject: Re: [PATCH] iwl3945: fix section type conflict on powerpc

On Wed, 2009-04-22 at 08:33 -0700, Johannes Berg wrote:
> For some reason on powerpc I get:
>
> drivers/net/wireless/iwlwifi/iwl3945-base.c:1416: error:
> __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
> drivers/net/wireless/iwlwifi/iwl3945-base.c:1416: error:
> __ksymtab_iwl3945_rx_queue_reset causes a section type conflict
>
> The function doesn't need to be exported, and unexporting fixes it,
> so I'm not thinking about what is causing it.
>
> Signed-off-by: Johannes Berg <[email protected]>
> ---
> drivers/net/wireless/iwlwifi/iwl3945-base.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl3945-base.c 2009-04-22 17:16:53.614082341 +0200
> +++ wireless-testing/drivers/net/wireless/iwlwifi/iwl3945-base.c 2009-04-22 17:16:55.382327490 +0200
> @@ -1413,7 +1413,6 @@ void iwl3945_rx_queue_reset(struct iwl_p
> rxq->free_count = 0;
> spin_unlock_irqrestore(&rxq->lock, flags);
> }
> -EXPORT_SYMBOL(iwl3945_rx_queue_reset);
>
> /*
> * this should be called while priv->lock is locked
>
>

Acked-by: Reinette Chatre <[email protected]>

Thank you

Reinette