2009-09-20 08:09:32

by Jaswinder Singh Rajput

Subject: [RFC][PATCH] b43: Comment unused functions lpphy_restore_dig_flt_state and lpphy_disable_rx_gain_override

Commenting unused functions lpphy_restore_dig_flt_state and
lpphy_disable_rx_gain_override, may be we need these functions in future.

This also fixed following compilation warnings :
CC [M] drivers/net/wireless/b43/phy_lp.o
drivers/net/wireless/b43/phy_lp.c:383: warning: ‘lpphy_restore_dig_flt_state’ defined but not used
drivers/net/wireless/b43/phy_lp.c:891: warning: ‘lpphy_disable_rx_gain_override’ defined but not used

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
drivers/net/wireless/b43/phy_lp.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c
index 3e02d96..9c31462 100644
--- a/drivers/net/wireless/b43/phy_lp.c
+++ b/drivers/net/wireless/b43/phy_lp.c
@@ -379,6 +379,8 @@ static void lpphy_save_dig_flt_state(struct b43_wldev *dev)
}
}

+/* lpphy_restore_dig_flt_state is unused but kept as a reference */
+#if 0
static void lpphy_restore_dig_flt_state(struct b43_wldev *dev)
{
static const u16 addr[] = {
@@ -399,6 +401,7 @@ static void lpphy_restore_dig_flt_state(struct b43_wldev *dev)
for (i = 0; i < ARRAY_SIZE(addr); i++)
b43_phy_write(dev, addr[i], lpphy->dig_flt_state[i]);
}
+#endif

static void lpphy_baseband_rev2plus_init(struct b43_wldev *dev)
{
@@ -887,6 +890,8 @@ static void lpphy_rev2plus_set_rx_gain(struct b43_wldev *dev, u32 gain)
}
}

+/* lpphy_disable_rx_gain_override is unused but kept as a reference */
+#if 0
static void lpphy_disable_rx_gain_override(struct b43_wldev *dev)
{
b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_0, 0xFFFE);
@@ -902,6 +907,7 @@ static void lpphy_disable_rx_gain_override(struct b43_wldev *dev)
b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_2, 0xFDFF);
}
}
+#endif

static void lpphy_enable_rx_gain_override(struct b43_wldev *dev)
{
--
1.6.4.4

2009-09-20 09:28:18

by Gábor Stefanik

Subject: Re: [RFC][PATCH] b43: Comment unused functions lpphy_restore_dig_flt_state and lpphy_disable_rx_gain_override

These will be needed for calibration. (My calibration RFC already
makes use of them.)

On Sun, Sep 20, 2009 at 10:09 AM, Jaswinder Singh Rajput
<[email protected]> wrote:
>
> Commenting unused functions lpphy_restore_dig_flt_state and
> lpphy_disable_rx_gain_override, may be we need these functions in future.
>
> This also fixed following compilation warnings :
> ?CC [M] ?drivers/net/wireless/b43/phy_lp.o
> drivers/net/wireless/b43/phy_lp.c:383: warning: ?lpphy_restore_dig_flt_state? defined but not used
> drivers/net/wireless/b43/phy_lp.c:891: warning: ?lpphy_disable_rx_gain_override? defined but not used
>
> Signed-off-by: Jaswinder Singh Rajput <[email protected]>
> ---
> ?drivers/net/wireless/b43/phy_lp.c | ? ?6 ++++++
> ?1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c
> index 3e02d96..9c31462 100644
> --- a/drivers/net/wireless/b43/phy_lp.c
> +++ b/drivers/net/wireless/b43/phy_lp.c
> @@ -379,6 +379,8 @@ static void lpphy_save_dig_flt_state(struct b43_wldev *dev)
> ? ? ? ?}
> ?}
>
> +/* lpphy_restore_dig_flt_state is unused but kept as a reference */
> +#if 0
> ?static void lpphy_restore_dig_flt_state(struct b43_wldev *dev)
> ?{
> ? ? ? ?static const u16 addr[] = {
> @@ -399,6 +401,7 @@ static void lpphy_restore_dig_flt_state(struct b43_wldev *dev)
> ? ? ? ?for (i = 0; i < ARRAY_SIZE(addr); i++)
> ? ? ? ? ? ? ? ?b43_phy_write(dev, addr[i], lpphy->dig_flt_state[i]);
> ?}
> +#endif
>
> ?static void lpphy_baseband_rev2plus_init(struct b43_wldev *dev)
> ?{
> @@ -887,6 +890,8 @@ static void lpphy_rev2plus_set_rx_gain(struct b43_wldev *dev, u32 gain)
> ? ? ? ?}
> ?}
>
> +/* lpphy_disable_rx_gain_override is unused but kept as a reference */
> +#if 0
> ?static void lpphy_disable_rx_gain_override(struct b43_wldev *dev)
> ?{
> ? ? ? ?b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_0, 0xFFFE);
> @@ -902,6 +907,7 @@ static void lpphy_disable_rx_gain_override(struct b43_wldev *dev)
> ? ? ? ? ? ? ? ?b43_phy_mask(dev, B43_LPPHY_RF_OVERRIDE_2, 0xFDFF);
> ? ? ? ?}
> ?}
> +#endif
>
> ?static void lpphy_enable_rx_gain_override(struct b43_wldev *dev)
> ?{
> --
> 1.6.4.4
>
>
>



--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)